diff options
| author | John Newbery <[email protected]> | 2017-11-16 11:52:59 -0500 |
|---|---|---|
| committer | John Newbery <[email protected]> | 2017-11-16 13:45:46 -0500 |
| commit | f0c4ab9a7034aca6be83fcb6cd8479cd19a196a2 (patch) | |
| tree | 9094a4b07d53ccb34a14475ea43f5617af96fef4 /src/httpserver.cpp | |
| parent | [tests] refactor check_last_announcement() in sendheaders.py (diff) | |
| download | discoin-f0c4ab9a7034aca6be83fcb6cd8479cd19a196a2.tar.xz discoin-f0c4ab9a7034aca6be83fcb6cd8479cd19a196a2.zip | |
[tests] fix flakiness in sendheaders.py
Fixes to sources of intermittent failure in sendheaders.py
- at the start of test_null_locators(), a new block is generated and
then a getheaders is sent. check_last_accouncement() is called to assert
that the headers message is received. However, the new block triggers an
inv to be sent over both P2P connections, so there's a race. If the inv
is received at the wrong time, the test fails.
- test_null_locators() ends by sending a block to the node under test.
At the start of test_nonnull_locators(), a block is mined and
check_last_announcement() is called to assert that the inv received is
for the same block. That means there's a race: if the inv from the block
sent in test_null_locators() is received at the wrong time, the test
fails.
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions