aboutsummaryrefslogtreecommitdiff
path: root/src/httpserver.cpp
diff options
context:
space:
mode:
authorJohn Newbery <[email protected]>2018-04-20 15:45:31 -0400
committerJohn Newbery <[email protected]>2018-04-20 15:45:31 -0400
commitc1d742025caec62cf38cea1166fa6c4d0f7e207b (patch)
tree152d3cf40e6463a35f6007474f7b80453af793fd /src/httpserver.cpp
parentMerge #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (diff)
downloaddiscoin-c1d742025caec62cf38cea1166fa6c4d0f7e207b.tar.xz
discoin-c1d742025caec62cf38cea1166fa6c4d0f7e207b.zip
[tests] Fix feature_block flakiness
feature_block.py occasionally fails on Travis. I believe this is due to a a race condition when reconnecting to bitcoind after a subtest that expects disconnection. If the test runs ahead and sends the INV for the subsequent test before we've received the initial sync getheaders, then we may end up sending two headers messages - one as a response to the initial sync getheaders and one in response to the INV getheaders. If both of those headers fail validation with a DoS score of 50 or higher, then we'll unexpectedly be disconnected. There is only one validation failure that has a DoS score bewteen 50 and 100, which is high-hash. That's why the test is failing immediately after the "Reject a block with invalid work" subtest. Fix is to wait for the initial getheaders from the peer before we start populating our blockstore. That way we won't have any invalid headers to respond to it with.
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions