diff options
| author | MarcoFalke <[email protected]> | 2018-03-19 16:49:53 -0400 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2018-03-19 16:49:55 -0400 |
| commit | 8ee5c7b747171e335793c74cd9d2f7491da58164 (patch) | |
| tree | 853cef2303289be82a5c002d409c0a0825e640b1 /src/httpserver.cpp | |
| parent | Merge #9753: Add static_assert to prevent VARINT(<signed value>) (diff) | |
| parent | Remove unreachable help conditions (diff) | |
| download | discoin-8ee5c7b747171e335793c74cd9d2f7491da58164.tar.xz discoin-8ee5c7b747171e335793c74cd9d2f7491da58164.zip | |
Merge #12727: [RPC] Remove unreachable help conditions in rpcwallet.cpp
e5468a19d1 Remove unreachable help conditions (lutangar)
Pull request description:
These conditions on `request.fHelp`, which appears in the body of the following functions are never reached:
* `walletpassphrase`
* `walletpassphrasechange`
* `encryptwallet`
```
...
if (request.fHelp || request.params.size() != 0) {
throw std::runtime_error("");
}
...
if (request.fHelp)
return true;
...
```
The first condition would throw if `request.fHelp` evaluates to `true`.
Tree-SHA512: 1aa41ed233c6bebae27151ab5cc67144d2a408335a3acef3c103e144d6343685f360b1146e14bc8dc1d53d00fcfc6ff1ab6a0eeb0805191172a23b306ab50b79
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions