diff options
| author | Wladimir J. van der Laan <[email protected]> | 2017-12-19 15:53:22 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2017-12-19 16:16:39 +0100 |
| commit | 81c89e966e1e08c3d94dc9d1d0a26034312c56ff (patch) | |
| tree | d67a7f18cd6b4a0b3fe54d50a918862264c24337 /src/httpserver.cpp | |
| parent | Merge #11946: tests: Remove unused variable (firstAddrnServices) (diff) | |
| parent | remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx (diff) | |
| download | discoin-81c89e966e1e08c3d94dc9d1d0a26034312c56ff.tar.xz discoin-81c89e966e1e08c3d94dc9d1d0a26034312c56ff.zip | |
Merge #11923: Wallet : remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx
ecf9b25 remove unused fNoncriticalErrors variable from CWalletDB::FindWalletTx (Pierre Rochard)
Pull request description:
The `CWalletDB::FindWalletTx` method was patterned after `CWalletDB::LoadWallet`, where `fNoncriticalErrors` is used when a tx check fails in `ReadKeyValue`.
Since `FindWalletTx` is only used by methods which are zapping txs, it makes sense that `ReadKeyValue` is not called and the tx is not checked, so I think that deleting the unused `fNoncriticalErrors` boolean variable and its conditional statement is appropriate.
Tree-SHA512: 0976eae97522719fdaeca1fb3f4a080561e46c06d0b8dc75e14262c6bc242998db3f7057183a230a1d7e4ac5fc348e9059f545b7d718ebbcdf6dcdfc63bcc286
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions