diff options
| author | practicalswift <[email protected]> | 2017-07-03 17:46:43 +0200 |
|---|---|---|
| committer | practicalswift <[email protected]> | 2017-07-15 14:26:50 +0200 |
| commit | 6835cb0ab26c913423cc2307c989579d05aabdcb (patch) | |
| tree | f624c3b4de8d9c619c99e1f5cbb3aaba6afada59 /src/httpserver.cpp | |
| parent | Merge #10769: [Qt] replace fee slider with a Dropdown, extend conf. targets (diff) | |
| download | discoin-6835cb0ab26c913423cc2307c989579d05aabdcb.tar.xz discoin-6835cb0ab26c913423cc2307c989579d05aabdcb.zip | |
Avoid static analyzer warnings regarding uninitialized arguments
Avoid static analyzer warnings regarding "Function call argument
is a pointer to uninitialized value" in cases where we are
intentionally using such arguments.
This is achieved by using ...
`f(b.begin(), b.end())` (`std::array<char, N>`)
... instead of ...
`f(b, b + N)` (`char b[N]`)
Rationale:
* Reduce false positives by guiding static analyzers regarding our
intentions.
Before this commit:
```
$ clang-tidy-3.5 -checks=* src/bench/base58.cpp
bench/base58.cpp:23:9: warning: Function call argument is a pointer to uninitialized value [clang-analyzer-core.CallAndMessage]
EncodeBase58(b, b + 32);
^
$ clang-tidy-3.5 -checks=* src/bench/verify_script.cpp
bench/verify_script.cpp:59:5: warning: Function call argument is a pointer to uninitialized value [clang-analyzer-core.CallAndMessage]
key.Set(vchKey, vchKey + 32, false);
^
$
```
After this commit:
```
$ clang-tidy-3.5 -checks=* src/bench/base58.cpp
$ clang-tidy-3.5 -checks=* src/bench/verify_script.cpp
$
```
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions