diff options
| author | Wladimir J. van der Laan <[email protected]> | 2019-10-28 13:41:45 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2019-10-28 13:41:45 +0100 |
| commit | f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf (patch) | |
| tree | b580be6a30428150b6ec40ca5da5bb96ee746fb1 /src/httprpc.cpp | |
| parent | Merge #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (diff) | |
| download | discoin-f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf.tar.xz discoin-f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf.zip | |
Fix occurences of c_str() used with size() to data()
Using `data()` better communicates the intent here.
Also, depending on how `c_str()` is implemented, this fixes undefined
behavior: The part of the string after the first NULL character might
have undefined contents.
Diffstat (limited to 'src/httprpc.cpp')
| -rw-r--r-- | src/httprpc.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/httprpc.cpp b/src/httprpc.cpp index 2c2f67b16..0437f0c7d 100644 --- a/src/httprpc.cpp +++ b/src/httprpc.cpp @@ -112,7 +112,7 @@ static bool multiUserAuthorized(std::string strUserPass) static const unsigned int KEY_SIZE = 32; unsigned char out[KEY_SIZE]; - CHMAC_SHA256(reinterpret_cast<const unsigned char*>(strSalt.c_str()), strSalt.size()).Write(reinterpret_cast<const unsigned char*>(strPass.c_str()), strPass.size()).Finalize(out); + CHMAC_SHA256(reinterpret_cast<const unsigned char*>(strSalt.data()), strSalt.size()).Write(reinterpret_cast<const unsigned char*>(strPass.data()), strPass.size()).Finalize(out); std::vector<unsigned char> hexvec(out, out+KEY_SIZE); std::string strHashFromPass = HexStr(hexvec); |