Update to Berkeley DB 5.3

Old BerkeleyDB version such as 5.1 are being removed from most Linux
distribution.

See: https://bugs.gentoo.org/792222
See: https://fedoraproject.org/wiki/Changes/Libdb_deprecated

3 files changed, 19 insertions, 34 deletions

diff --git a/doc/Building-Dogecoin-1.14-for-Mac.md b/doc/Building-Dogecoin-1.14-for-Mac.md
index 22e2b0fe9..242e9e875 100644
--- a/doc/Building-Dogecoin-1.14-for-Mac.md
+++ b/doc/Building-Dogecoin-1.14-for-Mac.md
@@ -40,49 +40,34 @@ Install Boost lib via Brew from source, and link it to be sure:
     $brew install boost --build-from-source --HEAD

     $brew link boost167

 

-### Get, Patch And Compile BDB 5.1 ###

+### Get, Patch And Compile BDB 5.3 ###

 

-Download bdb 5.1.29 source from Oracle.

+Download bdb 5.3.28 source from Oracle.

 

-    $curl -o db-5.1.29.tar.gz http://download.oracle.com/berkeley-db/db-5.1.29.tar.gz

-    $tar xvfz db-5.1.29.tar.gz

-    $cd db-5.1.29

+    $curl -o db-5.3.28.tar.gz http://download.oracle.com/berkeley-db/db-5.3.28.tar.gz

+    $tar xvfz db-5.3.28.tar.gz

+    $cd db-5.3.28

 

-Patch bdb 5.1.29 from our patchfiles

-

-    $cd src

-    $cd dbinc

-    $patch -b atomic.h ~/dogecoin/depends/patches/bdb-5.1.29-clang-osx/atomic.h.patch

-    $cd ..

-    $cd mp

-    $patch -b mp_fget.c ~/dogecoin/depends/patches/bdb-5.1.29-clang-osx/mp_fget.c.patch

-    $patch -b mp_mvcc.c ~/dogecoin/depends/patches/bdb-5.1.29-clang-osx/mp_mvcc.c.patch

-    $patch -b mp_region.c ~/dogecoin/depends/patches/bdb-5.1.29-clang-osx/mp_region.c.patch

-    $cd ..

-    $cd mutex

-    $patch -b mut_method.c ~/dogecoin/depends/patches/bdb-5.1.29-clang-osx/mut_method.c.patch

-    $patch -b mut_tas.c ~/dogecoin/depends/patches/bdb-5.1.29-clang-osx/mut_tas.c.patch

-

-Build BDB 5.1.29

+Build BDB 5.3.28

 

     $cd ../.. 

     $cd build_unix

     $../dist/configure CXX=clang++ --enable-cxx

     $make

-    $sudo mkdir /usr/local/BerkeleyDB.5.1

-    $sudo chown $(whoami):admin /usr/local/BerkeleyDB.5.1

+    $sudo mkdir /usr/local/BerkeleyDB.5.3

+    $sudo chown $(whoami):admin /usr/local/BerkeleyDB.5.3

     $sudo make install

 

 ### Set some environment variables and links for bdb and openssl ###

 

-    $export LDFLAGS=-L/usr/local/BerkeleyDB.5.1/lib

-    $export CPPFLAGS=-I/usr/local/BerkeleyDB.5.1/include

+    $export LDFLAGS=-L/usr/local/BerkeleyDB.5.3/lib

+    $export CPPFLAGS=-I/usr/local/BerkeleyDB.5.3/include

     

    _**NOTE:** for MacOS BigSur (11.1) or later, and possibly Catalina (10.15) you will also have to include the "OBJC_OLD_DISPATCH_PROTOTYPES=1" flag._

    

    _So in this case you want the above export to be:_

     

-    $export CPPFLAGS="-I/usr/local/BerkeleyDB.5.1/include -DOBJC_OLD_DISPATCH_PROTOTYPES=1"

+    $export CPPFLAGS="-I/usr/local/BerkeleyDB.5.3/include -DOBJC_OLD_DISPATCH_PROTOTYPES=1"

    

    _(Note that the quotes are required.)_

 	

diff --git a/doc/build-osx.md b/doc/build-osx.md
index 97536bbea..d00aac366 100644
--- a/doc/build-osx.md
+++ b/doc/build-osx.md
@@ -17,7 +17,7 @@ Dependencies
 ----------------------
 
     brew install automake libtool boost miniupnpc openssl pkg-config protobuf qt5 libevent
-    brew install berkeley-db # You need to make sure you install a version >= 5.1.29, but as close to 5.1.29 as possible. Check the homebrew docs to find out how to install older versions.
+    brew install berkeley-db # You need to make sure you install a version >= 5.3.28, but as close to 5.3.28 as possible. Check the homebrew docs to find out how to install older versions.
 
 If you want to build the disk image with `make deploy` (.dmg / optional), you need RSVG
 
diff --git a/doc/build-unix.md b/doc/build-unix.md
index 21927e149..4821cade0 100644
--- a/doc/build-unix.md
+++ b/doc/build-unix.md
@@ -43,7 +43,7 @@ Wallet is optional to run a node, see [Wallet](#wallet) section to enable them.
  Library     | Purpose          | Description
  ------------|------------------|----------------------
  miniupnpc   | UPnP Support     | Firewall-jumping support
- libdb5.1    | Berkeley DB      | Wallet storage (only needed when wallet enabled)
+ libdb5.3    | Berkeley DB      | Wallet storage (only needed when wallet enabled)
  qt          | GUI              | GUI toolkit (only needed when GUI enabled)
  protobuf    | Payments in GUI  | Data interchange format used for payment protocol (only needed when GUI enabled)
  libqrencode | QR codes in GUI  | Optional for generating QR codes (only needed when GUI enabled)
@@ -108,24 +108,24 @@ Create `dogecoin-qt`, the core wallet GUI.
 #### Wallet
 BerkeleyDB is required for wallet functionality and use the `wallet.dat` file.
 
-By default, **Dogecoin Core expect BerkeleyDB 5.1**.  
+By default, **Dogecoin Core expect BerkeleyDB 5.3**.
 You can use a different version by specifying `--with-incompatible-bdb` flag.
 
 If no package is available for your distribution  in optional dependencies, you can build BerkeleyDB from source :
 ```bash
-# Install script for BerkeleyDB 5.1
+# Install script for BerkeleyDB 5.3
 
 # BerkeleyDB installation directory
 BDB_PREFIX=$(pwd)/bdb
 mkdir $BDB_PREFIX
 
 # Fetch the source and verify shasum
-wget 'http://download.oracle.com/berkeley-db/db-5.1.29.NC.tar.gz'
-echo '08238e59736d1aacdd47cfb8e68684c695516c37f4fbe1b8267dde58dc3a576c db-5.1.29.NC.tar.gz' | sha256sum -c
+wget 'http://download.oracle.com/berkeley-db/db-5.3.28.NC.tar.gz'
+echo '76a25560d9e52a198d37a31440fd07632b5f1f8f9f2b6d5438f4bc3e7c9013efdb-5.3.28.NC.tar.gz' | sha256sum -c
 
 # Extract sources
-tar -xzvf db-5.1.29.NC.tar.gz
-cd db-5.1.29.NC/build_unix/
+tar -xzvf db-5.3.28.NC.tar.gz
+cd db-5.3.28.NC/build_unix/
 
 # Apply patch (see https://gist.github.com/danieldk/5700533)
 sed -i  's/__atomic_compare_exchange/__atomic_compare_exchange_db/g' ../src/dbinc/atomic.h