aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWladimir J. van der Laan <[email protected]>2015-08-26 12:04:34 +0200
committerWladimir J. van der Laan <[email protected]>2015-08-26 12:06:08 +0200
commit981fd92bc5e233b15cb4205f17c9b707e6846a18 (patch)
tree7649a5389c7174dff7c5c0fe3be7bc0db1949ac5
parentMerge pull request #6576 (diff)
parentrpc-tests: re-enable rpc-tests for Windows (diff)
downloaddiscoin-981fd92bc5e233b15cb4205f17c9b707e6846a18.tar.xz
discoin-981fd92bc5e233b15cb4205f17c9b707e6846a18.zip
Merge pull request #6590
bd30c3d rpc-tests: re-enable rpc-tests for Windows (Cory Fields) a193387 net: Set SO_REUSEADDR for Windows too (Cory Fields)
-rwxr-xr-xqa/pull-tester/rpc-tests.sh5
-rw-r--r--src/net.cpp4
2 files changed, 3 insertions, 6 deletions
diff --git a/qa/pull-tester/rpc-tests.sh b/qa/pull-tester/rpc-tests.sh
index 5d581819d..555d2c224 100755
--- a/qa/pull-tester/rpc-tests.sh
+++ b/qa/pull-tester/rpc-tests.sh
@@ -8,11 +8,6 @@ CURDIR=$(cd $(dirname "$0"); pwd)
export BITCOINCLI=${BUILDDIR}/qa/pull-tester/run-bitcoin-cli
export BITCOIND=${REAL_BITCOIND}
-if [ "x${EXEEXT}" = "x.exe" ]; then
- echo "Win tests currently disabled"
- exit 0
-fi
-
#Run the tests
testScripts=(
diff --git a/src/net.cpp b/src/net.cpp
index fb5726a2b..8fda5140c 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -1625,8 +1625,10 @@ bool BindListenPort(const CService &addrBind, string& strError, bool fWhiteliste
setsockopt(hListenSocket, SOL_SOCKET, SO_NOSIGPIPE, (void*)&nOne, sizeof(int));
#endif
// Allow binding if the port is still in TIME_WAIT state after
- // the program was closed and restarted. Not an issue on windows!
+ // the program was closed and restarted.
setsockopt(hListenSocket, SOL_SOCKET, SO_REUSEADDR, (void*)&nOne, sizeof(int));
+#else
+ setsockopt(hListenSocket, SOL_SOCKET, SO_REUSEADDR, (const char*)&nOne, sizeof(int));
#endif
// Set to non-blocking, incoming connections will also inherit this