diff options
| author | MarcoFalke <[email protected]> | 2017-08-09 11:17:41 +0200 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2017-08-09 11:17:49 +0200 |
| commit | 4b5a7ce0c301ad971f383eb60f61bf9b4026efda (patch) | |
| tree | a80979f07c81881365584554bf14c6bd46fd095f | |
| parent | Merge #10695: [qa] Rewrite BIP65/BIP66 functional tests (diff) | |
| parent | Capitalize bullet points in CONTRIBUTING guide (diff) | |
| download | discoin-4b5a7ce0c301ad971f383eb60f61bf9b4026efda.tar.xz discoin-4b5a7ce0c301ad971f383eb60f61bf9b4026efda.zip | |
Merge #11003: Docs: Capitalize bullet points in CONTRIBUTING guide
13b1e9a16 Capitalize bullet points in CONTRIBUTING guide (Evan Klitzke)
Pull request description:
English grammar dictates that these bullet points should be capitalized.
This also makes the capitalization style consistent with the rest of the
document, e.g. the "Decision Making Process" section.
Tree-SHA512: 59f5a8941180ff3862ba63d364c27fd83d2e144299a71b2e784d58f806e8a02d7951dcc80fcc7152d0c78c2d1f5a22db1236af7ea6b9abece8dbe93533e4b65c
| -rw-r--r-- | CONTRIBUTING.md | 12 | ||||
| -rw-r--r-- | test/functional/README.md | 2 |
2 files changed, 7 insertions, 7 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f5d63517b..4e67af627 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -170,13 +170,13 @@ judge the general consensus of contributors. In general, all pull requests must: - - have a clear use case, fix a demonstrable bug or serve the greater good of + - Have a clear use case, fix a demonstrable bug or serve the greater good of the project (for example refactoring for modularisation); - - be well peer reviewed; - - have unit tests and functional tests where appropriate; - - follow code style guidelines; - - not break the existing test suite; - - where bugs are fixed, where possible, there should be unit tests + - Be well peer reviewed; + - Have unit tests and functional tests where appropriate; + - Follow code style guidelines; + - Not break the existing test suite; + - Where bugs are fixed, where possible, there should be unit tests demonstrating the bug and also proving the fix. This helps prevent regression. Patches that change Bitcoin consensus rules are considerably more involved than diff --git a/test/functional/README.md b/test/functional/README.md index 96fe0becc..44efda33d 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -90,7 +90,7 @@ on nodes 2 and up. - Implement a (generator) function called `get_tests()` which yields `TestInstance`s. Each `TestInstance` consists of: - - a list of `[object, outcome, hash]` entries + - A list of `[object, outcome, hash]` entries * `object` is a `CBlock`, `CTransaction`, or `CBlockHeader`. `CBlock`'s and `CTransaction`'s are tested for acceptance. `CBlockHeader`s can be used so that the test runner can deliver |