diff options
| author | Wladimir J. van der Laan <[email protected]> | 2018-09-10 17:57:33 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <[email protected]> | 2018-09-10 17:57:47 +0200 |
| commit | 321075609d23a1e23b7b905294516a497c14d07d (patch) | |
| tree | 25695070b6e9ae91b51a97bef7202f085a23bad8 | |
| parent | Merge #14183: depends: Remove unused Qt 4 dependencies (diff) | |
| parent | doc: release notes for -enablebip61 default change (diff) | |
| download | discoin-321075609d23a1e23b7b905294516a497c14d07d.tar.xz discoin-321075609d23a1e23b7b905294516a497c14d07d.zip | |
Merge #14054: p2p: Disable BIP 61 by default
faea5bfc5a975874acf763082852ed532ed81a95 doc: release notes for -enablebip61 default change (MarcoFalke)
fa14b54a872ef0ff755e3c1c0775904ca33cb5ff p2p: Disable BIP 61 by default (MarcoFalke)
Pull request description:
The live p2p network should not be used for debugging or as development aid when implementing the p2p protocol. Instead, applications should be tested locally (e.g. by inspecting the debug log of a validating node on the local network)
Using the p2p network for this purpose seems wasteful and even dangerous, as peers can not be trusted to send the correct reject messages or a reject message at all.
Tree-SHA512: 9c91ad035b5110942172a3b4b8a332a84e0c0aa9ee80f8134aeab63e66ac604841e68b04038681c288b716e5e0cbe38065eb5c7eb63fa72c3bdb3255a4b2d99d
| -rw-r--r-- | doc/release-notes.md | 10 | ||||
| -rw-r--r-- | src/net_processing.h | 2 |
2 files changed, 11 insertions, 1 deletions
diff --git a/doc/release-notes.md b/doc/release-notes.md index d3ba06765..2044a5009 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -59,6 +59,16 @@ support versions of macOS older than 10.10. Notable changes =============== +Command line option changes +--------------------------- + +The `-enablebip61` command line option (introduced in Bitcoin Core 0.17.0) is +used to toggle sending of BIP 61 reject messages. Reject messages have no use +case on the P2P network and are only logged for debugging by most network +nodes. The option will now by default be off for improved privacy and security +as well as reduced upload usage. The option can explicitly be turned on for +local-network debugging purposes. + Example item ------------ diff --git a/src/net_processing.h b/src/net_processing.h index f16d00032..496c3c7b0 100644 --- a/src/net_processing.h +++ b/src/net_processing.h @@ -15,7 +15,7 @@ static const unsigned int DEFAULT_MAX_ORPHAN_TRANSACTIONS = 100; /** Default number of orphan+recently-replaced txn to keep around for block reconstruction */ static const unsigned int DEFAULT_BLOCK_RECONSTRUCTION_EXTRA_TXN = 100; /** Default for BIP61 (sending reject messages) */ -static constexpr bool DEFAULT_ENABLE_BIP61 = true; +static constexpr bool DEFAULT_ENABLE_BIP61{false}; class PeerLogicValidation final : public CValidationInterface, public NetEventsInterface { private: |