diff options
| author | MarcoFalke <[email protected]> | 2019-01-25 11:53:39 -0500 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2019-01-25 11:53:41 -0500 |
| commit | ab46fe6ec1b37e88c5a06ee7a06ab31cbd18304f (patch) | |
| tree | c8aa12f794e992574669f07a6fa329a190a3f6ce | |
| parent | Merge #15233: Prevent mutex lock fail even if --enable-debug (diff) | |
| parent | Docs: Update python docs to reflect that wildcard imports are disallowed (diff) | |
| download | discoin-ab46fe6ec1b37e88c5a06ee7a06ab31cbd18304f.tar.xz discoin-ab46fe6ec1b37e88c5a06ee7a06ab31cbd18304f.zip | |
Merge #15249: Docs: Update python docs to reflect that wildcard imports are disallowed
f618c58b75 Docs: Update python docs to reflect that wildcard imports are disallowed (Ben Woosley)
Pull request description:
These have been disallowed via flake8 since: #13054
Tree-SHA512: f41651fd883e3786a7e87c4aa4c54749308e576287f2f88da3f1d8d0f59e14519d99061f1efd05b8745f495f87a14286cea576f1507d10ccd226f8cf2f2b3cc8
| -rw-r--r-- | test/functional/README.md | 2 | ||||
| -rwxr-xr-x | test/functional/example_test.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/functional/README.md b/test/functional/README.md index bce0d5db2..628c77eb1 100644 --- a/test/functional/README.md +++ b/test/functional/README.md @@ -26,7 +26,7 @@ don't have test cases for. The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126). - See [the python lint script](/test/lint/lint-python.sh) that checks for violations that could lead to bugs and issues in the test code. -- Avoid wildcard imports where possible +- Avoid wildcard imports - Use a module-level docstring to describe what the test is testing, and how it is testing it. - When subclassing the BitcoinTestFramwork, place overrides for the diff --git a/test/functional/example_test.py b/test/functional/example_test.py index be3544ee7..f367e4fca 100755 --- a/test/functional/example_test.py +++ b/test/functional/example_test.py @@ -13,7 +13,7 @@ is testing and *how* it's being tested # libraries then local imports). from collections import defaultdict -# Avoid wildcard * imports if possible +# Avoid wildcard * imports from test_framework.blocktools import (create_block, create_coinbase) from test_framework.messages import CInv from test_framework.mininode import ( |