diff options
| author | MarcoFalke <[email protected]> | 2017-06-20 13:54:10 +0200 |
|---|---|---|
| committer | MarcoFalke <[email protected]> | 2017-06-20 13:55:05 +0200 |
| commit | 999923e4bbc62920810d4d149a4938cfd657408a (patch) | |
| tree | e417710a3b79b224357a4819aa9db0013ef2a396 | |
| parent | Merge #10555: [tests] various improvements to zmq_test.py (diff) | |
| download | discoin-999923e4bbc62920810d4d149a4938cfd657408a.tar.xz discoin-999923e4bbc62920810d4d149a4938cfd657408a.zip | |
[qa] util: Check return code after closing bitcoind proc
This has no effect on the outcome of test cases, but
prints shorter and less confusing tracebacks on fails.
I.e. does not print an obvious "ConnectionRefusedError"
when shutting down the nodes due to an invalid return code.
| -rw-r--r-- | test/functional/test_framework/util.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py index 2b0f32c2b..8a2ac015f 100644 --- a/test/functional/test_framework/util.py +++ b/test/functional/test_framework/util.py @@ -300,8 +300,8 @@ def _stop_node(node, i): except http.client.CannotSendRequest as e: logger.exception("Unable to stop node") return_code = bitcoind_processes[i].wait(timeout=BITCOIND_PROC_WAIT_TIMEOUT) - assert_equal(return_code, 0) del bitcoind_processes[i] + assert_equal(return_code, 0) def _stop_nodes(nodes): """Stop multiple bitcoind test nodes |