diff options
| author | Luke Dashjr <[email protected]> | 2017-01-08 20:33:33 +0000 |
|---|---|---|
| committer | Luke Dashjr <[email protected]> | 2017-02-27 20:45:18 +0000 |
| commit | 9756be382e64ab060e8d8fd3cefe5bbccc44bb45 (patch) | |
| tree | 9cd5d9d4a8c364e3e83eaa14e15c7e2a22e6e3e3 | |
| parent | More tightly couple EnsureWalletIsAvailable with GetWalletForJSONRPCRequest w... (diff) | |
| download | discoin-9756be382e64ab060e8d8fd3cefe5bbccc44bb45.tar.xz discoin-9756be382e64ab060e8d8fd3cefe5bbccc44bb45.zip | |
Wallet/RPC: Use filename rather than CWallet pointer, for lockwallet RPCRunLater job name
The job name is logged, and could pose as an information leak to someone attacking the process, helping them counteract ASLR protections
| -rw-r--r-- | src/wallet/rpcwallet.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp index 60f08b91c..148f0abe8 100644 --- a/src/wallet/rpcwallet.cpp +++ b/src/wallet/rpcwallet.cpp @@ -2077,7 +2077,7 @@ UniValue walletpassphrase(const JSONRPCRequest& request) int64_t nSleepTime = request.params[1].get_int64(); pwallet->nRelockTime = GetTime() + nSleepTime; - RPCRunLater(strprintf("lockwallet_%u", uintptr_t(pwallet)), boost::bind(LockWallet, pwallet), nSleepTime); + RPCRunLater(strprintf("lockwallet(%s)", pwallet->strWalletFile), boost::bind(LockWallet, pwallet), nSleepTime); return NullUniValue; } |