diff options
| author | Jonas Schnelli <[email protected]> | 2017-10-03 20:14:58 -0700 |
|---|---|---|
| committer | Jonas Schnelli <[email protected]> | 2017-10-03 20:15:11 -0700 |
| commit | 093074b84395a5b562bc378971d29c89da4202a4 (patch) | |
| tree | ba589edf075d55434d1171c70daf0abb2c2673c4 | |
| parent | Merge #11433: qa: Restore bitcoin-util-test py2 compatibility (diff) | |
| parent | Fix launchctl not being able to stop bitcoind (diff) | |
| download | discoin-093074b84395a5b562bc378971d29c89da4202a4.tar.xz discoin-093074b84395a5b562bc378971d29c89da4202a4.zip | |
Merge #11419: Utils: Fix launchctl not being able to stop bitcoind
ab5bba778 Fix launchctl not being able to stop bitcoind (Alejandro Avilés)
Pull request description:
`bitcoind` should not be launched as daemon from the Launch Agent. Otherwise, the process cannot be stopped from `launchctl stop`/`launchctl unload`.
To reproduce the issue:
```console
$ launchctl load ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist
$ pgrep -fla bitcoin
60225 /usr/local/opt/bitcoin/bin/bitcoind
$ launchctl unload ~/Library/LaunchAgents/org.bitcoin.bitcoind.plist
```
Wait a few seconds and then run `pgrep` again:
```console
$ pgrep -fla bitcoin
60225 /usr/local/opt/bitcoin/bin/bitcoind
```
The node is still running. This happens because Launch Agent is not supposed to run programs as daemons, since the agent makes sure they run in the background. Running them as daemons makes the Launch Agent lose control of the process and, so, it cannot be stopped.
Tree-SHA512: 5342e1a858e478a226a1db292f1b8f8666bb252ee951753b131902c325ea3d47592cf245298decb423ac658a3175761b54dc2e7df6feea5343d65ba255613f67
| -rw-r--r-- | contrib/init/org.bitcoin.bitcoind.plist | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/contrib/init/org.bitcoin.bitcoind.plist b/contrib/init/org.bitcoin.bitcoind.plist index e94cd4466..95b5342f1 100644 --- a/contrib/init/org.bitcoin.bitcoind.plist +++ b/contrib/init/org.bitcoin.bitcoind.plist @@ -7,7 +7,6 @@ <key>ProgramArguments</key> <array> <string>/usr/local/bin/bitcoind</string> - <string>-daemon</string> </array> <key>RunAtLoad</key> <true/> |