Clippy lints

4 files changed, 26 insertions, 22 deletions

diff --git a/src/cache/mod.rs b/src/cache/mod.rs
index 98c6648..5058d38 100644
--- a/src/cache/mod.rs
+++ b/src/cache/mod.rs
@@ -770,19 +770,19 @@ impl Cache {
     #[doc(hidden)]
     pub fn update_with_channel_pins_update(&mut self, event: &ChannelPinsUpdateEvent) {
         if let Some(channel) = self.channels.get(&event.channel_id) {
-            channel.write().unwrap().last_pin_timestamp = event.last_pin_timestamp.clone();
+            channel.write().unwrap().last_pin_timestamp = event.last_pin_timestamp;
 
             return;
         }
 
         if let Some(channel) = self.private_channels.get_mut(&event.channel_id) {
-            channel.write().unwrap().last_pin_timestamp = event.last_pin_timestamp.clone();
+            channel.write().unwrap().last_pin_timestamp = event.last_pin_timestamp;
 
             return;
         }
 
         if let Some(group) = self.groups.get_mut(&event.channel_id) {
-            group.write().unwrap().last_pin_timestamp = event.last_pin_timestamp.clone();
+            group.write().unwrap().last_pin_timestamp = event.last_pin_timestamp;
 
             return;
         }
diff --git a/src/framework/help_commands.rs b/src/framework/help_commands.rs
index 3396f3c..a4dbe76 100644
--- a/src/framework/help_commands.rs
+++ b/src/framework/help_commands.rs
@@ -179,7 +179,7 @@ pub fn with_embeds(ctx: &mut Context,
 
                 for name in command_names {
                     let cmd = &commands[name];
-                    
+
                     if cmd.help_available {
                         let _ = write!(desc, "`{}`\n", name);
 
@@ -188,7 +188,7 @@ pub fn with_embeds(ctx: &mut Context,
                 }
 
                 if has_commands {
-                    e = e.field(|f| f.name(&group_name).value(&desc));
+                    e = e.field(|f| f.name(group_name).value(&desc));
                 }
             }
 
@@ -301,16 +301,16 @@ pub fn plain(ctx: &mut Context,
         let commands = remove_aliases(&group.commands);
         let mut command_names = commands.keys().collect::<Vec<_>>();
         command_names.sort();
-        
+
         for name in command_names {
             let cmd = &commands[name];
-            
+
             if cmd.help_available {
                 let _ = write!(group_help, "`{}` ", name);
             }
         }
 
-        if group_help.len() > 0 {
+        if !group_help.is_empty() {
             let _ = write!(result, "**{}:** ", group_name);
 
             if let Some(ref x) = group.prefix {
diff --git a/src/framework/mod.rs b/src/framework/mod.rs
index 38615c8..20da188 100644
--- a/src/framework/mod.rs
+++ b/src/framework/mod.rs
@@ -590,15 +590,16 @@ impl Framework {
     ///
     /// ```rust
     /// # #[macro_use] extern crate serenity;
-    /// command!(ping(_ctx, msg) {
-    ///     msg.channel_id.say("pong!");
-    /// });
     /// #
     /// # fn main() {
-    /// # use serenity::Client;
-    /// # let mut client = Client::login("token");
+    /// #     use serenity::Client;
+    /// #     let mut client = Client::login("token");
     /// #
     /// client.with_framework(|f| f.on("ping", ping));
+    ///
+    /// command!(ping(_ctx, msg) {
+    ///     let _ = msg.channel_id.say("pong!");
+    /// });
     /// # }
     /// ```
     pub fn on<F, S>(mut self, command_name: S, f: F) -> Self
@@ -702,15 +703,19 @@ impl Framework {
     /// use serenity::framework::DispatchError::{NotEnoughArguments, TooManyArguments};
     ///
     /// client.with_framework(|f| f
-    ///     .on_dispatch_error(|ctx, msg, error| {
+    ///     .on_dispatch_error(|_, msg, error| {
     ///         match error {
     ///             NotEnoughArguments { min, given } => {
-    ///                 msg.channel_id.say(&format!("Need {} arguments, but only got {}.", min, given));
-    ///             }
+    ///                 let s = format!("Need {} arguments, but only got {}.", min, given);
+    ///
+    ///                 let _ = msg.channel_id.say(&s);
+    ///             },
     ///             TooManyArguments { max, given } => {
-    ///                 msg.channel_id.say(&format!("Max arguments allowed is {}, but got {}.", max, given));
-    ///             }
-    ///             _ => println!("Unhandled dispatch error.")
+    ///                 let s = format!("Max arguments allowed is {}, but got {}.", max, given);
+    ///
+    ///                 let _ = msg.channel_id.say(&s);
+    ///             },
+    ///             _ => println!("Unhandled dispatch error."),
     ///         }
     ///     }));
     /// ```
@@ -746,7 +751,7 @@ impl Framework {
     /// # let mut client = Client::login("token");
     /// #
     /// client.with_framework(|f| f
-    ///     .before(|ctx, msg, cmd_name| {
+    ///     .before(|_, msg, cmd_name| {
     ///         if let Ok(channel) = msg.channel_id.get() {
     ///             //  Don't run unless in nsfw channel
     ///             if !channel.is_nsfw() {
@@ -755,6 +760,7 @@ impl Framework {
     ///         }
     ///
     ///         println!("Running command {}", cmd_name);
+    ///
     ///         true
     ///     }));
     /// ```
diff --git a/src/lib.rs b/src/lib.rs
index 8a2e680..4e0f267 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -89,12 +89,10 @@
 
 #[macro_use]
 extern crate bitflags;
-#[allow(unused_imports)]
 #[macro_use]
 extern crate log;
 #[macro_use]
 extern crate serde_derive;
-#[allow(unused_imports)]
 #[macro_use]
 extern crate serde_json;