From 138ddb54e42e71a384e059afe69e4e8172935d6d Mon Sep 17 00:00:00 2001 From: a1xd <68629610+a1xd@users.noreply.github.com> Date: Mon, 13 Sep 2021 23:00:53 -0400 Subject: fix potential leaks forms displayed with ShowDialog are only hidden when closed; Dispose must be called manually --- grapher/Form1.cs | 7 ++++++- grapher/Models/AccelGUI.cs | 5 ++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/grapher/Form1.cs b/grapher/Form1.cs index 32c5c77..b5a49c8 100644 --- a/grapher/Form1.cs +++ b/grapher/Form1.cs @@ -34,7 +34,12 @@ namespace grapher ToolStripMenuItem HelpMenuItem = new ToolStripMenuItem("&Help"); HelpMenuItem.DropDownItems.AddRange(new ToolStripItem[] { - new ToolStripMenuItem("&About", null, (s, e) => new AboutBox(driverVersion).ShowDialog()) + new ToolStripMenuItem("&About", null, (s, e) => { + using (var form = new AboutBox(driverVersion)) + { + form.ShowDialog(); + } + }) }); menuStrip1.Items.AddRange(new ToolStripItem[] { HelpMenuItem }); diff --git a/grapher/Models/AccelGUI.cs b/grapher/Models/AccelGUI.cs index e15aba9..1836b65 100644 --- a/grapher/Models/AccelGUI.cs +++ b/grapher/Models/AccelGUI.cs @@ -154,7 +154,10 @@ namespace grapher error_message = e.Message; } - new MessageDialog(error_message, "bad input").ShowDialog(); + using (var form = new MessageDialog(error_message, "bad input")) + { + form.ShowDialog(); + } } public void RefreshActive() -- cgit v1.2.3