From 29987b56e1dafff4a850eef4e668a364340fc59b Mon Sep 17 00:00:00 2001
From: Graydon Hoare <graydon@mozilla.com>
Date: Thu, 5 Aug 2010 10:04:11 -0700
Subject: Move 'as' precedence up to just above relational; support indexing
 str and vec by all integral types. Closes #94.

---
 src/boot/be/x86.ml   | 19 ++++++++++++-------
 src/boot/fe/pexp.ml  | 50 +++++++++++++++++++++++++-------------------------
 src/boot/me/trans.ml |  3 ++-
 src/boot/me/type.ml  |  9 +++++----
 4 files changed, 44 insertions(+), 37 deletions(-)

(limited to 'src/boot')

diff --git a/src/boot/be/x86.ml b/src/boot/be/x86.ml
index 217149c7..2ec34890 100644
--- a/src/boot/be/x86.ml
+++ b/src/boot/be/x86.ml
@@ -1936,15 +1936,20 @@ let zero (dst:Il.cell) (count:Il.operand) : Asm.frag =
 ;;
 
 let mov (signed:bool) (dst:Il.cell) (src:Il.operand) : Asm.frag =
-  if is_ty8 (Il.cell_scalar_ty dst) || is_ty8 (Il.operand_scalar_ty src)
+  if is_ty8 (Il.cell_scalar_ty dst)
   then
     begin
-      (match dst with
-           Il.Reg (Il.Hreg r, _)
-           -> assert (is_ok_r8 r) | _ -> ());
-      (match src with
-           Il.Cell (Il.Reg (Il.Hreg r, _))
-           -> assert (is_ok_r8 r) | _ -> ());
+      match dst with
+          Il.Reg (Il.Hreg r, _) -> assert (is_ok_r8 r)
+        | _ -> ()
+    end;
+
+  if is_ty8 (Il.operand_scalar_ty src)
+  then
+    begin
+      match src with
+          Il.Cell (Il.Reg (Il.Hreg r, _)) -> assert (is_ok_r8 r)
+        | _ -> ()
     end;
 
   match (signed, dst, src) with
diff --git a/src/boot/fe/pexp.ml b/src/boot/fe/pexp.ml
index fb2d91a0..3e17e0e4 100644
--- a/src/boot/fe/pexp.ml
+++ b/src/boot/fe/pexp.ml
@@ -817,11 +817,33 @@ and parse_or_pexp (ps:pstate) : pexp =
     step lhs
 
 
+and parse_as_pexp (ps:pstate) : pexp =
+  let apos = lexpos ps in
+  let pexp = ctxt "as pexp" parse_or_pexp ps in
+  let rec step accum =
+    match peek ps with
+        AS ->
+          bump ps;
+          let tapos = lexpos ps in
+          let t = parse_ty ps in
+          let bpos = lexpos ps in
+          let t = span ps tapos bpos t in
+          let node =
+            span ps apos bpos
+              (PEXP_unop ((Ast.UNOP_cast t), accum))
+          in
+            step node
+
+      | _ -> accum
+  in
+    step pexp
+
+
 and parse_relational_pexp (ps:pstate) : pexp =
   let name = "relational pexp" in
   let apos = lexpos ps in
-  let lhs = ctxt (name ^ " lhs") parse_or_pexp ps in
-  let build = binop_build ps name apos parse_or_pexp in
+  let lhs = ctxt (name ^ " lhs") parse_as_pexp ps in
+  let build = binop_build ps name apos parse_as_pexp in
   let rec step accum =
     match peek ps with
         LT -> build accum step Ast.BINOP_lt
@@ -883,30 +905,8 @@ and parse_oror_pexp (ps:pstate) : pexp =
     step lhs
 
 
-and parse_as_pexp (ps:pstate) : pexp =
-  let apos = lexpos ps in
-  let pexp = ctxt "as pexp" parse_oror_pexp ps in
-  let rec step accum =
-    match peek ps with
-        AS ->
-          bump ps;
-          let tapos = lexpos ps in
-          let t = parse_ty ps in
-          let bpos = lexpos ps in
-          let t = span ps tapos bpos t in
-          let node =
-            span ps apos bpos
-              (PEXP_unop ((Ast.UNOP_cast t), accum))
-          in
-            step node
-
-      | _ -> accum
-  in
-    step pexp
-
-
 and parse_pexp (ps:pstate) : pexp =
-  parse_as_pexp ps
+  parse_oror_pexp ps
 
 and parse_mutable_and_pexp (ps:pstate) : (Ast.mutability * pexp) =
   let mutability = parse_mutability ps in
diff --git a/src/boot/me/trans.ml b/src/boot/me/trans.ml
index f2bb2287..f54a5d65 100644
--- a/src/boot/me/trans.ml
+++ b/src/boot/me/trans.ml
@@ -914,7 +914,8 @@ let trans_visitor
       let atop = trans_atom at in
       let unit_sz = ty_sz_in_current_frame ty in
       let idx = next_vreg_cell word_sty in
-        emit (Il.binary Il.UMUL idx atop unit_sz);
+        mov idx atop;
+        emit (Il.binary Il.UMUL idx (Il.Cell idx) unit_sz);
         let elt_mem = trans_bounds_check (deref cell) (Il.Cell idx) in
           (Il.Mem (elt_mem, referent_type abi ty), ty)
     in
diff --git a/src/boot/me/type.ml b/src/boot/me/type.ml
index 787855f0..23210ea1 100644
--- a/src/boot/me/type.ml
+++ b/src/boot/me/type.ml
@@ -380,19 +380,20 @@ let check_stmt (cx:Semant.ctxt) : (fn_ctx -> Ast.stmt -> unit) =
               sprintf_itype ()
 
         | `Type (Ast.TY_vec ty_vec), Ast.COMP_atom atom ->
-            demand Ast.TY_int (check_atom atom);
+            demand_integer (check_atom atom);
             LTYPE_mono ty_vec
 
         | `Type (Ast.TY_vec _), _ ->
-            Common.err None "the vector type '%a' must be indexed via an int"
+            Common.err None
+              "the vector type '%a' must be indexed by an integral type"
               sprintf_itype ()
 
         | `Type Ast.TY_str, Ast.COMP_atom atom ->
-            demand Ast.TY_int (check_atom atom);
+            demand_integer (check_atom atom);
             LTYPE_mono (Ast.TY_mach Common.TY_u8)
 
         | `Type Ast.TY_str, _ ->
-            Common.err None "strings must be indexed via an int"
+            Common.err None "strings must be indexed by an integral type"
 
         | `Type (Ast.TY_box ty_box), Ast.COMP_deref -> LTYPE_mono ty_box
 
-- 
cgit v1.2.3


From 9da8101cc83116c3804393a1abe3eb5e1d0dc02a Mon Sep 17 00:00:00 2001
From: Graydon Hoare <graydon@mozilla.com>
Date: Thu, 5 Aug 2010 13:26:28 -0700
Subject: Something is wrong with the emitter size cache; disable for now,
 possibly put out flaming tinderboxes.

---
 src/boot/me/trans.ml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src/boot')

diff --git a/src/boot/me/trans.ml b/src/boot/me/trans.ml
index f54a5d65..8c280ebd 100644
--- a/src/boot/me/trans.ml
+++ b/src/boot/me/trans.ml
@@ -674,7 +674,9 @@ let trans_visitor
                      (Printf.sprintf "calculated size %s is %s"
                         (string_of_size size)
                         (oper_str res)));
-            htab_put (emitter_size_cache()) size res;
+
+            (* FIXME: this appears to be incorrect; investigate why.*)
+            (* htab_put (emitter_size_cache()) size res; *)
             res
 
 
-- 
cgit v1.2.3


From db561b52fff4466ac4de4fc807ebc0c253c7cd73 Mon Sep 17 00:00:00 2001
From: Graydon Hoare <graydon@mozilla.com>
Date: Thu, 5 Aug 2010 17:44:35 -0700
Subject: Degrade emitter size cache to just a flat hashtable with regular
 flushes (sigh) and re-introduce horrible bounce-off-spill hack for DIV, MUL,
 etc.

---
 src/boot/be/il.ml    |  4 ++--
 src/boot/be/x86.ml   | 42 ++++++++++++++++++++++++++++++------
 src/boot/me/trans.ml | 60 ++++++++++++++++++++++++++++++----------------------
 3 files changed, 73 insertions(+), 33 deletions(-)

(limited to 'src/boot')

diff --git a/src/boot/be/il.ml b/src/boot/be/il.ml
index 792e83e2..172d8661 100644
--- a/src/boot/be/il.ml
+++ b/src/boot/be/il.ml
@@ -695,7 +695,7 @@ type emitter = { mutable emit_pc: int;
                  emit_target_specific: (emitter -> quad -> unit);
                  mutable emit_quads: quads;
                  emit_annotations: (int,string) Hashtbl.t;
-                 emit_size_cache: ((size,operand) Hashtbl.t) Stack.t;
+                 emit_size_cache: (size,operand) Hashtbl.t;
                  emit_node: node_id option;
                }
 
@@ -722,7 +722,7 @@ let new_emitter
     emit_target_specific = emit_target_specific;
     emit_quads = Array.create 4 badq;
     emit_annotations = Hashtbl.create 0;
-    emit_size_cache = Stack.create ();
+    emit_size_cache = Hashtbl.create 0;
     emit_node = node;
   }
 ;;
diff --git a/src/boot/be/x86.ml b/src/boot/be/x86.ml
index 2ec34890..55b101bb 100644
--- a/src/boot/be/x86.ml
+++ b/src/boot/be/x86.ml
@@ -302,11 +302,41 @@ let emit_target_specific
               | Il.IMOD | Il.UMOD ->
                   let dst_eax = hr_like_cell eax dst in
                   let lhs_eax = hr_like_op eax lhs in
-                  let rhs_ecx = hr_like_op ecx lhs in
-                    if lhs <> (Il.Cell lhs_eax)
-                    then mov lhs_eax lhs;
-                    if rhs <> (Il.Cell rhs_ecx)
-                    then mov rhs_ecx rhs;
+                  let rhs_ecx = hr_like_op ecx rhs in
+                    (* Horrible: we bounce complex mul inputs off spill slots
+                     * to ensure non-interference between the temporaries used
+                     * during mem-base-reg reloads and the registers we're
+                     * preparing.  *)
+                  let next_spill_like op =
+                    Il.Mem (Il.next_spill_slot e
+                              (Il.ScalarTy (Il.operand_scalar_ty op)))
+                  in
+                  let is_mem op =
+                    match op with
+                        Il.Cell (Il.Mem _) -> true
+                      | _ -> false
+                  in
+                  let bounce_lhs = is_mem lhs in
+                  let bounce_rhs = is_mem rhs in
+                  let lhs_spill = next_spill_like lhs in
+                  let rhs_spill = next_spill_like rhs in
+
+                    if bounce_lhs
+                    then mov lhs_spill lhs;
+
+                    if bounce_rhs
+                    then mov rhs_spill rhs;
+
+                    mov lhs_eax
+                      (if bounce_lhs
+                       then (Il.Cell lhs_spill)
+                       else lhs);
+
+                    mov rhs_ecx
+                      (if bounce_rhs
+                       then (Il.Cell rhs_spill)
+                       else rhs);
+                    
                     put (Il.Binary
                            { b with
                                Il.binary_lhs = (Il.Cell lhs_eax);
@@ -314,7 +344,7 @@ let emit_target_specific
                                Il.binary_dst = dst_eax; });
                     if dst <> dst_eax
                     then mov dst (Il.Cell dst_eax);
-
+                    
               | _ when (Il.Cell dst) <> lhs ->
                   mov dst lhs;
                   put (Il.Binary
diff --git a/src/boot/me/trans.ml b/src/boot/me/trans.ml
index 8c280ebd..b708bb26 100644
--- a/src/boot/me/trans.ml
+++ b/src/boot/me/trans.ml
@@ -163,7 +163,6 @@ let trans_visitor
          abi.Abi.abi_emit_target_specific
          vregs_ok fnid
     in
-      Stack.push (Hashtbl.create 0) e.Il.emit_size_cache;
       Stack.push e emitters;
   in
 
@@ -172,16 +171,20 @@ let trans_visitor
 
   let pop_emitter _ = ignore (Stack.pop emitters) in
   let emitter _ = Stack.top emitters in
-  let emitter_size_cache _ = Stack.top (emitter()).Il.emit_size_cache in
-  let push_emitter_size_cache _ =
-    Stack.push
-      (Hashtbl.copy (emitter_size_cache()))
-      (emitter()).Il.emit_size_cache
+  let emitter_size_cache _ = (emitter()).Il.emit_size_cache in
+  let flush_emitter_size_cache _ =
+    Hashtbl.clear (emitter_size_cache())
   in
-  let pop_emitter_size_cache _ =
-    ignore (Stack.pop (emitter()).Il.emit_size_cache)
+
+  let emit q =
+    begin
+      match q with
+        Il.Jmp _ -> flush_emitter_size_cache();
+        | _ -> ()
+    end;        
+    Il.emit (emitter()) q
   in
-  let emit q = Il.emit (emitter()) q in
+
   let next_vreg _ = Il.next_vreg (emitter()) in
   let next_vreg_cell t = Il.next_vreg_cell (emitter()) t in
   let next_spill_cell t =
@@ -190,12 +193,17 @@ let trans_visitor
     let spill_ta = (spill_mem, Il.ScalarTy t) in
       Il.Mem spill_ta
   in
-  let mark _ : quad_idx = (emitter()).Il.emit_pc in
+  let mark _ : quad_idx =
+    flush_emitter_size_cache ();
+    (emitter()).Il.emit_pc
+  in
   let patch_existing (jmp:quad_idx) (targ:quad_idx) : unit =
-    Il.patch_jump (emitter()) jmp targ
+    Il.patch_jump (emitter()) jmp targ;
+    flush_emitter_size_cache ();
   in
   let patch (i:quad_idx) : unit =
     Il.patch_jump (emitter()) i (mark());
+    flush_emitter_size_cache ();
     (* Insert a dead quad to ensure there's an otherwise-unused
      * jump-target here.
      *)
@@ -583,7 +591,13 @@ let trans_visitor
                 (string_of_size size)));
     let sub_sz = calculate_sz ty_params in
     match htab_search (emitter_size_cache()) size with
-        Some op -> op
+        Some op ->
+          iflog (fun _ -> annotate
+                   (Printf.sprintf "cached size %s is %s"
+                      (string_of_size size)
+                      (oper_str op)));
+          op
+
       | _ ->
           let res =
             match size with
@@ -674,9 +688,7 @@ let trans_visitor
                      (Printf.sprintf "calculated size %s is %s"
                         (string_of_size size)
                         (oper_str res)));
-
-            (* FIXME: this appears to be incorrect; investigate why.*)
-            (* htab_put (emitter_size_cache()) size res; *)
+            htab_put (emitter_size_cache()) size res;
             res
 
 
@@ -1926,8 +1938,8 @@ let trans_visitor
       : quad_idx list =
     emit (Il.cmp (Il.Cell (Il.Reg (force_to_reg lhs))) rhs);
     let jmp = mark() in
-    emit (Il.jmp cjmp Il.CodeNone);
-    [ jmp ]
+      emit (Il.jmp cjmp Il.CodeNone);
+      [ jmp ]
 
   and trans_compare
       ?ty_params:(ty_params=get_ty_params_of_current_frame())
@@ -1946,7 +1958,6 @@ let trans_visitor
       | _ -> trans_compare_simple cjmp lhs rhs
 
   and trans_cond (invert:bool) (expr:Ast.expr) : quad_idx list =
-
     let anno _ =
       iflog
         begin
@@ -2078,15 +2089,14 @@ let trans_visitor
             trans_atom a
 
   and trans_block (block:Ast.block) : unit =
+    flush_emitter_size_cache();
     trace_str cx.ctxt_sess.Session.sess_trace_block
       "entering block";
-    push_emitter_size_cache ();
     emit (Il.Enter (Hashtbl.find cx.ctxt_block_fixups block.id));
     Array.iter trans_stmt block.node;
     trace_str cx.ctxt_sess.Session.sess_trace_block
       "exiting block";
     emit Il.Leave;
-    pop_emitter_size_cache ();
     trace_str cx.ctxt_sess.Session.sess_trace_block
       "exited block";
 
@@ -4398,11 +4408,11 @@ let trans_visitor
                     let back_jmp =
                       trans_compare_simple Il.JB (Il.Cell dptr) (Il.Cell dlim)
                     in
-                    List.iter
-                      (fun j -> patch_existing j back_jmp_targ) back_jmp;
-                    let v = next_vreg_cell word_sty in
-                      mov v (Il.Cell src_fill);
-                      add_to dst_fill (Il.Cell v);
+                      List.iter
+                        (fun j -> patch_existing j back_jmp_targ) back_jmp;
+                      let v = next_vreg_cell word_sty in
+                        mov v (Il.Cell src_fill);
+                        add_to dst_fill (Il.Cell v);
         | t ->
             begin
               bug () "unsupported vector-append type %a" Ast.sprintf_ty t
-- 
cgit v1.2.3


From 514fb4b321d1d019a7bfcd64518d1162878cbf07 Mon Sep 17 00:00:00 2001
From: Roy Frostig <rfrostig@mozilla.com>
Date: Fri, 6 Aug 2010 15:43:59 -0700
Subject: Accept uint literals as literal patterns.

---
 src/boot/fe/item.ml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'src/boot')

diff --git a/src/boot/fe/item.ml b/src/boot/fe/item.ml
index 69fe5fc2..82ec2faf 100644
--- a/src/boot/fe/item.ml
+++ b/src/boot/fe/item.ml
@@ -253,7 +253,10 @@ and parse_stmts (ps:pstate) : Ast.stmt array =
                             let lv = name_to_lval apos bpos name in
                               Ast.PAT_tag (lv, paren_comma_list parse_pat ps)
 
-                      | LIT_INT _ | LIT_CHAR _ | LIT_BOOL _ ->
+                      | LIT_INT _
+                      | LIT_UINT _
+                      | LIT_CHAR _
+                      | LIT_BOOL _ ->
                           Ast.PAT_lit (Pexp.parse_lit ps)
 
                       | UNDERSCORE -> bump ps; Ast.PAT_wild
-- 
cgit v1.2.3


From fdb842f9e6d28b51fa51935d66c77011f27a436b Mon Sep 17 00:00:00 2001
From: Jeffrey Yasskin <jyasskin@gmail.com>
Date: Fri, 23 Jul 2010 19:27:55 -0700
Subject: Fix LLVM translation of modules.

---
 src/boot/llvm/lltrans.ml | 39 +++++++++++++++++++++++++++++----------
 1 file changed, 29 insertions(+), 10 deletions(-)

(limited to 'src/boot')

diff --git a/src/boot/llvm/lltrans.ml b/src/boot/llvm/lltrans.ml
index ee192725..c1ef49af 100644
--- a/src/boot/llvm/lltrans.ml
+++ b/src/boot/llvm/lltrans.ml
@@ -588,7 +588,7 @@ let trans_crate
     (* Maps a fn's or block's id to an LLVM metadata node (subprogram or
        lexical block) representing it. *)
   let (dbg_llscopes:(node_id, Llvm.llvalue) Hashtbl.t) = Hashtbl.create 0 in
-  let declare_mod_item
+  let rec declare_mod_item
       (name:Ast.ident)
       mod_item
       : unit =
@@ -616,9 +616,8 @@ let trans_crate
         | Ast.MOD_ITEM_type _ ->
             ()  (* Types get translated with their terms. *)
 
-        | Ast.MOD_ITEM_mod _ ->
-            ()  (* Modules simply contain other items that are translated
-                   on their own. *)
+        | Ast.MOD_ITEM_mod (_, items) ->
+            Hashtbl.iter declare_mod_item items
 
         | _ ->
             Common.unimpl (Some id)
@@ -807,6 +806,17 @@ let trans_crate
                             Ast.sprintf_lval lval)
       in
 
+      let trans_callee (fn:Ast.lval) : (Llvm.llvalue * Ast.ty) =
+        let fty = Hashtbl.find sem_cx.ctxt_all_lval_types (lval_base_id fn) in
+          if lval_base_is_item sem_cx fn then
+            let fn_item = lval_item sem_cx fn in
+            let llfn = Hashtbl.find llitems (fn_item.id) in
+              (llfn, fty)
+          else
+            (* indirect call to computed slot *)
+            trans_lval fn
+      in
+
       let trans_atom (atom:Ast.atom) : Llvm.llvalue =
         iflog (fun _ -> log sem_cx "trans_atom: %a" Ast.sprintf_atom atom);
         match atom with
@@ -959,7 +969,7 @@ let trans_crate
               | Ast.STMT_call (dest, fn, args) ->
                   let llargs = Array.map trans_atom args in
                   let (lldest, _) = trans_lval dest in
-                  let (llfn, _) = trans_lval fn in
+                  let (llfn, _) = trans_callee fn in
                   let llallargs = Array.append [| lldest; lltask |] llargs in
                   let llrv = build_call llfn llallargs "" llbuilder in
                     Llvm.set_instruction_call_conv Llvm.CallConv.c llrv;
@@ -1072,13 +1082,22 @@ let trans_crate
       ignore (Llvm.build_br llbodyblock llinitbuilder)
   in
 
-  let trans_mod_item
-      (_:Ast.ident)
-      { node = { Ast.decl_item = (item:Ast.mod_item') }; id = id }
+  let rec trans_mod_item
+      (name:Ast.ident)
+      mod_item
       : unit =
+    let { node = { Ast.decl_item = (item:Ast.mod_item') }; id = id } =
+      mod_item in
     match item with
-        Ast.MOD_ITEM_fn fn -> trans_fn fn id
-      | _ -> ()
+        Ast.MOD_ITEM_type _ ->
+          ()  (* Types get translated with their terms. *)
+      | Ast.MOD_ITEM_mod (_, items) ->
+          Hashtbl.iter trans_mod_item items
+      | Ast.MOD_ITEM_fn fn -> trans_fn fn id
+      | _ -> Common.unimpl (Some id)
+          "LLVM module declaration for: %a"
+            Ast.sprintf_mod_item (name, mod_item)
+
   in
 
   let exit_task_glue =
-- 
cgit v1.2.3


From a0cc4817e952f1a022b1ad9c01793db1735a579e Mon Sep 17 00:00:00 2001
From: Or Brostovski <tohava@gmail.com>
Date: Thu, 5 Aug 2010 03:44:29 +0300
Subject: Added AST logging, and modified AST for consistent handling of alt
 stmts.

- Modified the arm types, instead of a single arm type, there are now 2 (soon to be 3) arm types, one for each type of alt statement
- Added AST logging for constrained type (see fmt_constrained)
- Added AST logging for STMT_alt_type
- Created a generic fmt_arm for use with all alt statements
---
 src/boot/fe/ast.ml  | 75 ++++++++++++++++++++++++++++++++++++++++-------------
 src/boot/me/dead.ml |  3 ++-
 2 files changed, 59 insertions(+), 19 deletions(-)

(limited to 'src/boot')

diff --git a/src/boot/fe/ast.ml b/src/boot/fe/ast.ml
index 651b1e65..d4ace045 100644
--- a/src/boot/fe/ast.ml
+++ b/src/boot/fe/ast.ml
@@ -247,13 +247,13 @@ and stmt = stmt' identified
 and stmt_alt_tag =
     {
       alt_tag_lval: lval;
-      alt_tag_arms: arm array;
+      alt_tag_arms: tag_arm array;
     }
 
 and stmt_alt_type =
     {
       alt_type_lval: lval;
-      alt_type_arms: (ident * slot * stmt) array;
+      alt_type_arms: type_arm array;
       alt_type_else: stmt option;
     }
 
@@ -318,8 +318,11 @@ and pat =
   | PAT_slot of ((slot identified) * ident)
   | PAT_wild
 
-and arm' = pat * block
-and arm = arm' identified
+and tag_arm' = pat * block
+and tag_arm = tag_arm' identified
+
+and type_arm' = ident * slot * block
+and type_arm = type_arm' identified
 
 and atom =
     ATOM_literal of (lit identified)
@@ -646,6 +649,16 @@ and fmt_iso (ff:Format.formatter) (tiso:ty_iso) : unit =
   done;
   fmt ff "@]]@]"
 
+and fmt_constrained ff (ty, constrs) : unit =
+  fmt ff "@[";
+  fmt_ty ff ty;
+  fmt ff " : ";
+  fmt ff "@[";
+  fmt_constrs ff constrs;
+  fmt ff "@]";
+  fmt ff "@]";
+    
+
 and fmt_ty (ff:Format.formatter) (t:ty) : unit =
   match t with
     TY_any -> fmt ff "any"
@@ -687,7 +700,7 @@ and fmt_ty (ff:Format.formatter) (t:ty) : unit =
   | TY_tag ttag -> fmt_tag ff ttag
   | TY_iso tiso -> fmt_iso ff tiso
   | TY_idx idx -> fmt ff "<idx#%d>" idx
-  | TY_constrained _ -> fmt ff "?constrained?"
+  | TY_constrained ctrd -> fmt_constrained ff ctrd 
 
   | TY_obj (effect, fns) ->
       fmt_obox ff;
@@ -707,7 +720,13 @@ and fmt_ty (ff:Format.formatter) (t:ty) : unit =
 
 
 and fmt_constrs (ff:Format.formatter) (cc:constr array) : unit =
-  Array.iter (fmt_constr ff) cc
+  for i = 0 to (Array.length cc) - 1
+  do
+    if i != 0
+    then fmt ff ",@ ";
+    fmt_constr ff cc.(i)
+  done;
+  (* Array.iter (fmt_constr ff) cc *)
 
 and fmt_decl_constrs (ff:Format.formatter) (cc:constr array) : unit =
   if Array.length cc = 0
@@ -1204,25 +1223,45 @@ and fmt_stmt_body (ff:Format.formatter) (s:stmt) : unit =
           fmt_lval ff at.alt_tag_lval;
           fmt ff ") ";
           fmt_obr ff;
-          Array.iter (fmt_arm ff) at.alt_tag_arms;
+          Array.iter (fmt_tag_arm ff) at.alt_tag_arms;
           fmt_cbb ff;
 
-      | STMT_alt_type _ -> fmt ff "?stmt_alt_type?"
+      | STMT_alt_type at -> 
+          fmt_obox ff;
+          fmt ff "alt type (";
+          fmt_lval ff at.alt_type_lval;
+          fmt ff ") ";
+          fmt_obr ff;
+          Array.iter (fmt_type_arm ff) at.alt_type_arms;
+          fmt_cbb ff;
+          
       | STMT_alt_port _ -> fmt ff "?stmt_alt_port?"
       | STMT_note _ -> fmt ff "?stmt_note?"
       | STMT_slice _ -> fmt ff "?stmt_slice?"
   end
 
-and fmt_arm (ff:Format.formatter) (arm:arm) : unit =
-  let (pat, block) = arm.node in
-    fmt ff "@\n";
-    fmt_obox ff;
-    fmt ff "case (";
-    fmt_pat ff pat;
-    fmt ff ") ";
-    fmt_obr ff;
-    fmt_stmts ff block.node;
-    fmt_cbb ff;
+and fmt_arm 
+    (ff:Format.formatter) 
+    (fmt_arm_case_expr : Format.formatter -> unit)
+    (block : block) 
+    : unit =
+  fmt ff "@\n";
+  fmt_obox ff;
+  fmt ff "case (";
+  fmt_arm_case_expr ff;
+  fmt ff ") ";
+  fmt_obr ff;
+  fmt_stmts ff block.node;
+  fmt_cbb ff;
+  
+and fmt_tag_arm (ff:Format.formatter) (tag_arm:tag_arm) : unit =
+  let (pat, block) = tag_arm.node in
+    fmt_arm ff (fun ff -> fmt_pat ff pat) block;
+    
+and fmt_type_arm (ff:Format.formatter) (type_arm:type_arm) : unit =
+  let (_, slot, block) = type_arm.node in
+    fmt_arm ff (fun ff -> fmt_slot ff slot) block;
+      
 
 and fmt_pat (ff:Format.formatter) (pat:pat) : unit =
   match pat with
diff --git a/src/boot/me/dead.ml b/src/boot/me/dead.ml
index 61aa846a..7ef4bf8e 100644
--- a/src/boot/me/dead.ml
+++ b/src/boot/me/dead.ml
@@ -70,7 +70,8 @@ let dead_code_visitor
 
         | Ast.STMT_alt_type { Ast.alt_type_arms = arms;
                               Ast.alt_type_else = alt_type_else } ->
-            let arm_ids = Array.map (fun (_, _, block) -> block.id) arms in
+            let arm_ids = Array.map (fun { node = (_, _, block) } -> 
+                                       block.id) arms in
             let else_ids =
               begin
                 match alt_type_else with
-- 
cgit v1.2.3


From 122ea68b12ec1587f0fe0bd4737ae866e2a56c39 Mon Sep 17 00:00:00 2001
From: Or Brostovski <tohava@gmail.com>
Date: Fri, 6 Aug 2010 16:11:15 +0300
Subject: Added AST pretty printing for slice expression

---
 src/boot/fe/ast.ml | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

(limited to 'src/boot')

diff --git a/src/boot/fe/ast.ml b/src/boot/fe/ast.ml
index d4ace045..9cad5ce5 100644
--- a/src/boot/fe/ast.ml
+++ b/src/boot/fe/ast.ml
@@ -1237,7 +1237,13 @@ and fmt_stmt_body (ff:Format.formatter) (s:stmt) : unit =
           
       | STMT_alt_port _ -> fmt ff "?stmt_alt_port?"
       | STMT_note _ -> fmt ff "?stmt_note?"
-      | STMT_slice _ -> fmt ff "?stmt_slice?"
+      | STMT_slice (dst, src, slice) -> 
+          fmt_lval ff dst;
+          fmt ff " = ";
+          fmt_lval ff src;
+          fmt ff ".";
+          fmt_slice ff slice;
+          fmt ff ";";
   end
 
 and fmt_arm 
@@ -1275,6 +1281,27 @@ and fmt_pat (ff:Format.formatter) (pat:pat) : unit =
     | PAT_wild ->
         fmt ff "_"
 
+and fmt_slice (ff:Format.formatter) (slice:slice) : unit =
+  let fmt_slice_start = (match slice.slice_start with
+                             None -> (fun ff -> fmt ff "0")
+                           | Some atom -> (fun ff -> fmt_atom ff atom)) in
+    fmt ff "(@[";
+    fmt_slice_start ff;
+    begin
+      match slice.slice_len with
+          None -> fmt ff ","
+        | Some slice_len ->
+            fmt ff ",@ @[";
+            fmt_slice_start ff;
+            fmt ff " +@ ";
+            fmt_atom ff slice_len;
+            fmt ff "@]";
+    end;
+    fmt ff "@])";
+    
+
+    
+
 and fmt_decl_param (ff:Format.formatter) (param:ty_param) : unit =
   let (ident, (i, e)) = param in
   fmt_effect ff e;
-- 
cgit v1.2.3


From 459e86045707e39c692535e0e2394c143d08355e Mon Sep 17 00:00:00 2001
From: Or Brostovski <tohava@gmail.com>
Date: Fri, 6 Aug 2010 17:15:55 +0300
Subject: Added forgotten handling for alt_type_else, and also for stmt_note

---
 src/boot/fe/ast.ml | 36 ++++++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 10 deletions(-)

(limited to 'src/boot')

diff --git a/src/boot/fe/ast.ml b/src/boot/fe/ast.ml
index 9cad5ce5..efbd62ae 100644
--- a/src/boot/fe/ast.ml
+++ b/src/boot/fe/ast.ml
@@ -254,7 +254,14 @@ and stmt_alt_type =
     {
       alt_type_lval: lval;
       alt_type_arms: type_arm array;
-      alt_type_else: stmt option;
+      alt_type_else: block option;
+    }
+
+and stmt_alt_port =
+    {
+      (* else lval is a timeout value. *)
+      alt_port_arms: (lval * lval) array;
+      alt_port_else: (lval * block) option;
     }
 
 and block' = stmt array
@@ -264,12 +271,6 @@ and stmt_decl =
     DECL_mod_item of (ident * mod_item)
   | DECL_slot of (slot_key * (slot identified))
 
-and stmt_alt_port =
-    {
-      (* else lval is a timeout value. *)
-      alt_port_arms: (lval * lval) array;
-      alt_port_else: (lval * stmt) option;
-    }
 
 and stmt_while =
     {
@@ -1233,10 +1234,25 @@ and fmt_stmt_body (ff:Format.formatter) (s:stmt) : unit =
           fmt ff ") ";
           fmt_obr ff;
           Array.iter (fmt_type_arm ff) at.alt_type_arms;
+          begin
+            match at.alt_type_else with 
+                None -> ()
+              | Some block ->
+                  fmt ff "@\n";
+                  fmt_obox ff;
+                  fmt ff "case (_) ";
+                  fmt_obr ff;
+                  fmt_stmts ff block.node;
+                  fmt_cbb ff;
+          end;
           fmt_cbb ff;
-          
       | STMT_alt_port _ -> fmt ff "?stmt_alt_port?"
-      | STMT_note _ -> fmt ff "?stmt_note?"
+      | STMT_note at -> 
+          begin
+            fmt ff "note ";
+            fmt_atom ff at;
+            fmt ff ";"
+          end
       | STMT_slice (dst, src, slice) -> 
           fmt_lval ff dst;
           fmt ff " = ";
@@ -1245,7 +1261,7 @@ and fmt_stmt_body (ff:Format.formatter) (s:stmt) : unit =
           fmt_slice ff slice;
           fmt ff ";";
   end
-
+    
 and fmt_arm 
     (ff:Format.formatter) 
     (fmt_arm_case_expr : Format.formatter -> unit)
-- 
cgit v1.2.3