From 79ad55e1e0fe746a635e6814fbf048437c2d50ee Mon Sep 17 00:00:00 2001 From: Fuwn Date: Mon, 3 Apr 2023 02:47:11 +0000 Subject: refactor(handler): trait-based response --- src/handler.rs | 10 ++++++++-- src/router.rs | 15 +++++++++------ 2 files changed, 17 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/handler.rs b/src/handler.rs index f22e3b3..b283cdf 100644 --- a/src/handler.rs +++ b/src/handler.rs @@ -30,8 +30,14 @@ pub trait RouteResponse: impl RouteResponse for T where T: FnMut(RouteContext<'_>) -> Response + Send + Sync {} -pub type ErrorResponse = - Box) -> Response + Send + Sync>; +pub trait ErrorResponse: + FnMut(returnable::ErrorContext<'_>) -> Response + Send + Sync +{ +} + +impl ErrorResponse for T where T: FnMut(returnable::ErrorContext<'_>) -> Response + Send + Sync +{} + pub type Callback = Box) + Send + Sync>; pub type CleanupCallback = Box, &mut Response) + Send + Sync>; diff --git a/src/router.rs b/src/router.rs index 9917923..0f4af89 100644 --- a/src/router.rs +++ b/src/router.rs @@ -57,7 +57,7 @@ macro_rules! or_error { #[derive(Clone)] pub struct Router { routes: matchit::Router>>>, - error_handler: Arc>, + error_handler: Arc>>, private_key_file_name: String, ca_file_name: String, headers: Arc>>, @@ -151,12 +151,15 @@ impl Router { /// # Examples /// /// ```rust - /// windmark::Router::new().set_error_handler(Box::new(|_| { - /// windmark::Response::success("You have encountered an error!") - /// })); + /// windmark::Router::new().set_error_handler(|_| { + /// windmark::success!("You have encountered an error!") + /// }); /// ``` - pub fn set_error_handler(&mut self, handler: ErrorResponse) -> &mut Self { - self.error_handler = Arc::new(Mutex::new(handler)); + pub fn set_error_handler( + &mut self, + handler: impl ErrorResponse + 'static, + ) -> &mut Self { + self.error_handler = Arc::new(Mutex::new(Box::new(handler))); self } -- cgit v1.2.3