From 6909271fa6488c2ba285aa67f2faa502bd5b6be6 Mon Sep 17 00:00:00 2001
From: Fuwn <contact@fuwn.me>
Date: Wed, 5 Apr 2023 02:47:07 +0000
Subject: feat(route): merge async and sync mount functions !!

---
 src/handler/response/route.rs | 18 ++++++-------
 src/response.rs               |  7 +++++
 src/router.rs                 | 60 ++++++++++++++++---------------------------
 3 files changed, 37 insertions(+), 48 deletions(-)

(limited to 'src')

diff --git a/src/handler/response/route.rs b/src/handler/response/route.rs
index 91265a3..0196363 100644
--- a/src/handler/response/route.rs
+++ b/src/handler/response/route.rs
@@ -16,27 +16,25 @@
 // Copyright (C) 2022-2022 Fuwn <contact@fuwn.me>
 // SPDX-License-Identifier: GPL-3.0-only
 
-use std::{future::Future, pin::Pin};
+use std::future::Future;
+
+use async_trait::async_trait;
 
 use crate::{context::RouteContext, Response};
 
 #[allow(clippy::module_name_repetitions)]
+#[async_trait]
 pub trait RouteResponse: Send + Sync {
-  fn call(
-    &mut self,
-    context: RouteContext<'_>,
-  ) -> Pin<Box<dyn Future<Output = Response> + Send>>;
+  async fn call(&mut self, context: RouteContext<'_>) -> Response;
 }
 
+#[async_trait]
 impl<T, F> RouteResponse for T
 where
   T: FnMut(RouteContext<'_>) -> F + Send + Sync,
   F: Future<Output = Response> + Send + 'static,
 {
-  fn call(
-    &mut self,
-    context: RouteContext<'_>,
-  ) -> Pin<Box<dyn Future<Output = Response> + Send>> {
-    Box::pin((*self)(context))
+  async fn call(&mut self, context: RouteContext<'_>) -> Response {
+    (*self)(context).await
   }
 }
diff --git a/src/response.rs b/src/response.rs
index 2a615a7..9a8efb8 100644
--- a/src/response.rs
+++ b/src/response.rs
@@ -144,3 +144,10 @@ impl Response {
     self
   }
 }
+
+impl std::future::IntoFuture for Response {
+  type IntoFuture = std::future::Ready<Self::Output>;
+  type Output = Self;
+
+  fn into_future(self) -> Self::IntoFuture { std::future::ready(self) }
+}
diff --git a/src/router.rs b/src/router.rs
index e1785dc..69849fb 100644
--- a/src/router.rs
+++ b/src/router.rs
@@ -20,6 +20,7 @@
 
 use std::{
   error::Error,
+  future::IntoFuture,
   sync::{Arc, Mutex},
   time,
 };
@@ -65,7 +66,7 @@ macro_rules! or_error {
 /// response generation, panics, logging, and more.
 #[derive(Clone)]
 pub struct Router {
-  routes:                matchit::Router<Arc<Mutex<Box<dyn RouteResponse>>>>,
+  routes: matchit::Router<Arc<AsyncMutex<Box<dyn RouteResponse>>>>,
   error_handler:         Arc<Mutex<Box<dyn ErrorResponse>>>,
   private_key_file_name: String,
   ca_file_name:          String,
@@ -133,59 +134,41 @@ impl Router {
 
   /// Map routes to URL paths
   ///
-  /// # Examples
-  ///
-  /// ```rust
-  /// windmark::Router::new()
-  ///   .mount("/", windmark::success!("This is the index page!"))
-  ///   .mount("/test", windmark::success!("This is a test page!"));
-  /// ```
-  ///
-  /// # Panics
-  ///
-  /// May panic if the route cannot be mounted.
-  pub fn mount(
-    &mut self,
-    route: impl Into<String> + AsRef<str>,
-    mut handler: impl FnMut(RouteContext<'_>) -> Response + Send + Sync + 'static,
-  ) -> &mut Self {
-    self.mount_async(route, move |context| {
-      let response = handler(context);
-
-      async move { response }
-    });
-
-    self
-  }
-
-  /// Map routes to URL paths; with async support
+  /// Supports both synchronous and asynchronous handlers
   ///
   /// # Examples
   ///
   /// ```rust
-  /// windmark::Router::new().mount_async("/", |_| {
-  ///   async { windmark::Response::success("This is the index page!") }
-  /// });
+  /// use windmark::Response;
+  ///
+  /// windmark::Router::new()
+  ///   .mount("/", |_| {
+  ///     async { Response::success("This is the index page!") }
+  ///   })
+  ///   .mount("/about", |_| async { Response::success("About that...") });
   /// ```
   ///
   /// # Panics
   ///
   /// May panic if the route cannot be mounted.
-  pub fn mount_async<R>(
+  pub fn mount<R>(
     &mut self,
     route: impl Into<String> + AsRef<str>,
     mut handler: impl FnMut(RouteContext<'_>) -> R + Send + Sync + 'static,
   ) -> &mut Self
   where
-    R: std::future::Future<Output = Response> + Send + 'static,
+    R: IntoFuture<Output = Response> + Send + 'static,
+    <R as IntoFuture>::IntoFuture: Send,
   {
     self
       .routes
       .insert(
         route.into(),
-        Arc::new(Mutex::new(Box::new(move |context: RouteContext<'_>| {
-          Box::pin(handler(context))
-        }))),
+        Arc::new(AsyncMutex::new(Box::new(
+          move |context: RouteContext<'_>| {
+            Box::pin(handler(context).into_future())
+          },
+        ))),
       )
       .unwrap();
 
@@ -419,7 +402,8 @@ impl Router {
         ));
       }
 
-      let handler = (*route.value).lock().unwrap().call(RouteContext::new(
+      let mut lock = (*route.value).lock().await;
+      let handler = lock.call(RouteContext::new(
         stream.get_ref(),
         &url,
         &route.params,
@@ -669,7 +653,7 @@ impl Router {
   /// use windmark::Response;
   ///
   /// windmark::Router::new().attach_stateless(|r| {
-  ///   r.mount_async(
+  ///   r.mount(
   ///     "/module",
   ///     Box::new(|_| Response::success("This is a module!")),
   ///   );
@@ -688,7 +672,7 @@ impl Router {
   ///
   /// mod windmark_example {
   ///   pub fn module(router: &mut windmark::Router) {
-  ///     router.mount_async(
+  ///     router.mount(
   ///       "/module",
   ///       Box::new(|_| windmark::Response::success("This is a module!")),
   ///     );
-- 
cgit v1.2.3