From 0917354dc0b79d1ac414392ae036f784eb397113 Mon Sep 17 00:00:00 2001 From: Fuwn Date: Wed, 18 Feb 2026 12:29:25 -0800 Subject: refactor: share folder menu hierarchy across views --- Sora/Views/BookmarkMenuButtonView.swift | 64 ++++++++------------------------- 1 file changed, 14 insertions(+), 50 deletions(-) (limited to 'Sora/Views/BookmarkMenuButtonView.swift') diff --git a/Sora/Views/BookmarkMenuButtonView.swift b/Sora/Views/BookmarkMenuButtonView.swift index 5e737ff..8446539 100644 --- a/Sora/Views/BookmarkMenuButtonView.swift +++ b/Sora/Views/BookmarkMenuButtonView.swift @@ -14,60 +14,24 @@ struct BookmarkMenuButtonView: View { let isBookmarked = settings.bookmarks.contains { bookmark in Set(bookmark.tags) == Set(tags) } + let folderHierarchy = FolderHierarchy(folders: settings.folders) Menu { - ForEach(settings.folders.filter { $0.topLevelName == nil }, id: \.id) { folder in - Button(action: { - settings.addBookmark(provider: provider, tags: tags, folder: folder.id) - }) { - Label(folder.name, systemImage: "folder") - } - .disabled(isBookmarkedInFolder(folderId: folder.id)) - } - - let topLevelFolders = settings.folders - .reduce(into: [String: [SettingsFolder]]()) { result, folder in - guard let topLevelName = folder.topLevelName else { return } - - result[topLevelName, default: []].append(folder) - } + FolderMenuView( + folderHierarchy: folderHierarchy, + onSelectFolder: { folderIdentifier in + settings.addBookmark(provider: provider, tags: tags, folder: folderIdentifier) + }, + onCreateTopLevelUncategorized: { topLevelName in + let newFolder = SettingsFolder(name: topLevelName) - ForEach(topLevelFolders.keys.sorted(), id: \.self) { topLevelName in - Menu { - let topLevelFolder = settings.folders.first { $0.name == topLevelName } - - if let topLevelFolder { - Button(action: { - settings.addBookmark(provider: provider, tags: tags, folder: topLevelFolder.id) - }) { - Text("Uncategorized") - } - .disabled(isBookmarkedInFolder(folderId: topLevelFolder.id)) - } else { - Button(action: { - let newFolder = SettingsFolder(name: topLevelName) - - settings.folders.append(newFolder) - settings.addBookmark(provider: provider, tags: tags, folder: newFolder.id) - }) { - Text("Uncategorized") - } - } - - Divider() - - ForEach(topLevelFolders[topLevelName] ?? [], id: \.id) { folder in - Button(action: { - settings.addBookmark(provider: provider, tags: tags, folder: folder.id) - }) { - Text(folder.shortName) - } - .disabled(isBookmarkedInFolder(folderId: folder.id)) - } - } label: { - Text(topLevelName) + settings.folders.append(newFolder) + settings.addBookmark(provider: provider, tags: tags, folder: newFolder.id) + }, + isFolderDisabled: { folderIdentifier in + isBookmarkedInFolder(folderId: folderIdentifier) } - } + ) Button(action: { isNewCollectionAlertPresented = true -- cgit v1.2.3