aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFuwn <[email protected]>2025-06-12 04:13:16 -0700
committerFuwn <[email protected]>2025-06-12 04:13:16 -0700
commitcc5da25ce9d9809d2a3d1a3033e4f8db33e3d6f7 (patch)
tree16db71c54cc0057a426c0852162d757565b0991a
parentfix(CleanMangaList): Missing reactive set state (diff)
downloaddue.moe-cc5da25ce9d9809d2a3d1a3033e4f8db33e3d6f7.tar.xz
due.moe-cc5da25ce9d9809d2a3d1a3033e4f8db33e3d6f7.zip
refactor(List): Simplify get-set structure of stateBin usage
-rw-r--r--src/lib/List/Anime/CleanAnimeList.svelte13
-rw-r--r--src/lib/List/Manga/CleanMangaList.svelte13
2 files changed, 4 insertions, 22 deletions
diff --git a/src/lib/List/Anime/CleanAnimeList.svelte b/src/lib/List/Anime/CleanAnimeList.svelte
index 597d27ac..22e8f581 100644
--- a/src/lib/List/Anime/CleanAnimeList.svelte
+++ b/src/lib/List/Anime/CleanAnimeList.svelte
@@ -66,17 +66,8 @@
? 'Completed'
: 'Due';
const filterKey = `${filterKind}AnimeListFilter`;
- let selectedList = ($stateBin[filterKey] as string) || 'All';
- onMount(() => {
- if (browser) {
- const storedValue = $stateBin[filterKey];
-
- if (typeof storedValue === 'string') selectedList = storedValue;
- }
- });
-
- $: $stateBin[filterKey] = selectedList;
+ $: selectedList = ($stateBin[filterKey] as string) || 'All';
$: filteredMedia =
selectedList === 'All' || !$settings.displayMediaListFilter
@@ -158,7 +149,7 @@
Force refresh
</button>
{:else if $settings.displayMediaListFilter}
- <select bind:value={selectedList}>
+ <select bind:value={$stateBin[filterKey]}>
<option value="All">All</option>
{#each lists as list}
diff --git a/src/lib/List/Manga/CleanMangaList.svelte b/src/lib/List/Manga/CleanMangaList.svelte
index 6f2a9f72..eb54df8c 100644
--- a/src/lib/List/Manga/CleanMangaList.svelte
+++ b/src/lib/List/Manga/CleanMangaList.svelte
@@ -50,17 +50,8 @@
);
const filterKind = due ? 'due' : 'completed';
const filterKey = `${filterKind}MangaListFilter`;
- let selectedList = ($stateBin[filterKey] as string) || 'All';
- onMount(() => {
- if (browser) {
- const storedValue = $stateBin[filterKey];
-
- if (typeof storedValue === 'string') selectedList = storedValue;
- }
- });
-
- $: $stateBin[filterKey] = selectedList;
+ $: selectedList = ($stateBin[filterKey] as string) || 'All';
$: filteredMedia =
selectedList === 'All' || !$settings.displayMediaListFilter
@@ -145,7 +136,7 @@
You can re-enable it later in the <a href={root('/settings')}>Settings</a>.
</span>
{:else if $settings.displayMediaListFilter}
- <select bind:value={selectedList}>
+ <select bind:value={$stateBin[filterKey]}>
<option value="All">All</option>
{#each lists as list}