1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
|
// Copyright Epic Games, Inc. All Rights Reserved.
#include "macrunner.h"
#if ZEN_WITH_COMPUTE_SERVICES && ZEN_PLATFORM_MAC
# include <zencore/compactbinary.h>
# include <zencore/compactbinarypackage.h>
# include <zencore/except.h>
# include <zencore/except_fmt.h>
# include <zencore/filesystem.h>
# include <zencore/fmtutils.h>
# include <zencore/timer.h>
# include <zencore/trace.h>
# include <fcntl.h>
# include <sandbox.h>
# include <signal.h>
# include <sys/wait.h>
# include <unistd.h>
namespace zen::compute {
using namespace std::literals;
namespace {
// All helper functions in this namespace are async-signal-safe (safe to call
// between fork() and execve()). They use only raw syscalls and avoid any
// heap allocation, stdio, or other non-AS-safe operations.
void WriteToFd(int Fd, const char* Buf, size_t Len)
{
while (Len > 0)
{
ssize_t Written = write(Fd, Buf, Len);
if (Written <= 0)
{
break;
}
Buf += Written;
Len -= static_cast<size_t>(Written);
}
}
[[noreturn]] void WriteErrorAndExit(int ErrorPipeFd, const char* Msg, int Errno)
{
// Write the message prefix
size_t MsgLen = 0;
for (const char* P = Msg; *P; ++P)
{
++MsgLen;
}
WriteToFd(ErrorPipeFd, Msg, MsgLen);
// Append ": " and the errno string if non-zero
if (Errno != 0)
{
WriteToFd(ErrorPipeFd, ": ", 2);
const char* ErrStr = strerror(Errno);
size_t ErrLen = 0;
for (const char* P = ErrStr; *P; ++P)
{
++ErrLen;
}
WriteToFd(ErrorPipeFd, ErrStr, ErrLen);
}
_exit(127);
}
// Build a Seatbelt profile string that denies everything by default and
// allows only the minimum needed for the worker to execute: process ops,
// system library reads, worker directory (read-only), and sandbox directory
// (read-write). Network access is denied implicitly by the deny-default policy.
std::string BuildSandboxProfile(const std::string& SandboxPath, const std::string& WorkerPath)
{
std::string Profile;
Profile.reserve(1024);
Profile += "(version 1)\n";
Profile += "(deny default)\n";
Profile += "(allow process*)\n";
Profile += "(allow sysctl-read)\n";
Profile += "(allow file-read-metadata)\n";
// System library paths needed for dynamic linker and runtime
Profile += "(allow file-read* (subpath \"/usr\"))\n";
Profile += "(allow file-read* (subpath \"/System\"))\n";
Profile += "(allow file-read* (subpath \"/Library\"))\n";
Profile += "(allow file-read* (subpath \"/dev\"))\n";
Profile += "(allow file-read* (subpath \"/private/var/db/dyld\"))\n";
Profile += "(allow file-read* (subpath \"/etc\"))\n";
// Worker directory: read-only
Profile += "(allow file-read* (subpath \"";
Profile += WorkerPath;
Profile += "\"))\n";
// Sandbox directory: read+write
Profile += "(allow file-read* file-write* (subpath \"";
Profile += SandboxPath;
Profile += "\"))\n";
return Profile;
}
} // anonymous namespace
MacProcessRunner::MacProcessRunner(ChunkResolver& Resolver,
const std::filesystem::path& BaseDir,
DeferredDirectoryDeleter& Deleter,
WorkerThreadPool& WorkerPool,
bool Sandboxed)
: LocalProcessRunner(Resolver, BaseDir, Deleter, WorkerPool)
, m_Sandboxed(Sandboxed)
{
// Restore SIGCHLD to default behavior so waitpid() can properly collect
// child exit status. zenserver/main.cpp sets SIGCHLD to SIG_IGN which
// causes the kernel to auto-reap children, making waitpid() return
// -1/ECHILD instead of the exit status we need.
struct sigaction Action = {};
sigemptyset(&Action.sa_mask);
Action.sa_handler = SIG_DFL;
sigaction(SIGCHLD, &Action, nullptr);
if (m_Sandboxed)
{
ZEN_INFO("Seatbelt sandboxing enabled for child processes");
}
}
SubmitResult
MacProcessRunner::SubmitAction(Ref<RunnerAction> Action)
{
ZEN_TRACE_CPU("MacProcessRunner::SubmitAction");
std::optional<PreparedAction> Prepared = PrepareActionSubmission(Action);
if (!Prepared)
{
return SubmitResult{.IsAccepted = false};
}
// Build environment array from worker descriptor
CbObject WorkerDescription = Prepared->WorkerPackage.GetObject();
std::vector<std::string> EnvStrings;
for (auto& It : WorkerDescription["environment"sv])
{
EnvStrings.emplace_back(It.AsString());
}
std::vector<char*> Envp;
Envp.reserve(EnvStrings.size() + 1);
for (auto& Str : EnvStrings)
{
Envp.push_back(Str.data());
}
Envp.push_back(nullptr);
// Build argv: <worker_exe_path> -Build=build.action
std::string_view ExecPath = WorkerDescription["path"sv].AsString();
std::filesystem::path ExePath = Prepared->WorkerPath / std::filesystem::path(ExecPath);
std::string ExePathStr = ExePath.string();
std::string BuildArg = "-Build=build.action";
std::vector<char*> ArgV;
ArgV.push_back(ExePathStr.data());
ArgV.push_back(BuildArg.data());
ArgV.push_back(nullptr);
ZEN_DEBUG("Executing: {} {} (sandboxed={})", ExePathStr, BuildArg, m_Sandboxed);
std::string SandboxPathStr = Prepared->SandboxPath.string();
std::string WorkerPathStr = Prepared->WorkerPath.string();
// Pre-fork: build sandbox profile and create error pipe
std::string SandboxProfile;
int ErrorPipe[2] = {-1, -1};
if (m_Sandboxed)
{
SandboxProfile = BuildSandboxProfile(SandboxPathStr, WorkerPathStr);
if (pipe(ErrorPipe) != 0)
{
throw zen::runtime_error("pipe() for sandbox error pipe failed: {}", strerror(errno));
}
fcntl(ErrorPipe[0], F_SETFD, FD_CLOEXEC);
fcntl(ErrorPipe[1], F_SETFD, FD_CLOEXEC);
}
pid_t ChildPid = fork();
if (ChildPid < 0)
{
int SavedErrno = errno;
if (m_Sandboxed)
{
close(ErrorPipe[0]);
close(ErrorPipe[1]);
}
throw zen::runtime_error("fork() failed: {}", strerror(SavedErrno));
}
if (ChildPid == 0)
{
// Child process
if (m_Sandboxed)
{
// Close read end of error pipe — child only writes
close(ErrorPipe[0]);
// Apply Seatbelt sandbox profile
char* ErrorBuf = nullptr;
if (sandbox_init(SandboxProfile.c_str(), 0, &ErrorBuf) != 0)
{
// sandbox_init failed — write error to pipe and exit
if (ErrorBuf)
{
WriteErrorAndExit(ErrorPipe[1], ErrorBuf, 0);
// WriteErrorAndExit does not return, but sandbox_free_error
// is not needed since we _exit
}
WriteErrorAndExit(ErrorPipe[1], "sandbox_init failed", errno);
}
if (ErrorBuf)
{
sandbox_free_error(ErrorBuf);
}
if (chdir(SandboxPathStr.c_str()) != 0)
{
WriteErrorAndExit(ErrorPipe[1], "chdir to sandbox failed", errno);
}
execve(ExePathStr.c_str(), ArgV.data(), Envp.data());
WriteErrorAndExit(ErrorPipe[1], "execve failed", errno);
}
else
{
if (chdir(SandboxPathStr.c_str()) != 0)
{
_exit(127);
}
execve(ExePathStr.c_str(), ArgV.data(), Envp.data());
_exit(127);
}
}
// Parent process
if (m_Sandboxed)
{
// Close write end of error pipe — parent only reads
close(ErrorPipe[1]);
// Read from error pipe. If execve succeeded, pipe was closed by O_CLOEXEC
// and read returns 0. If setup failed, child wrote an error message.
char ErrBuf[512];
ssize_t BytesRead = read(ErrorPipe[0], ErrBuf, sizeof(ErrBuf) - 1);
close(ErrorPipe[0]);
if (BytesRead > 0)
{
// Sandbox setup or execve failed
ErrBuf[BytesRead] = '\0';
// Reap the child (it called _exit(127))
waitpid(ChildPid, nullptr, 0);
// Clean up the sandbox in the background
m_DeferredDeleter.Enqueue(Action->ActionLsn, std::move(Prepared->SandboxPath));
ZEN_ERROR("Sandbox setup failed for action {}: {}", Action->ActionLsn, ErrBuf);
Action->SetActionState(RunnerAction::State::Failed);
return SubmitResult{.IsAccepted = false};
}
}
// Store child pid as void* (same convention as zencore/process.cpp)
Ref<RunningAction> NewAction{new RunningAction()};
NewAction->Action = Action;
NewAction->ProcessHandle = reinterpret_cast<void*>(static_cast<intptr_t>(ChildPid));
NewAction->SandboxPath = std::move(Prepared->SandboxPath);
{
RwLock::ExclusiveLockScope _(m_RunningLock);
m_RunningMap[Prepared->ActionLsn] = std::move(NewAction);
}
Action->SetActionState(RunnerAction::State::Running);
return SubmitResult{.IsAccepted = true};
}
void
MacProcessRunner::SweepRunningActions()
{
ZEN_TRACE_CPU("MacProcessRunner::SweepRunningActions");
std::vector<Ref<RunningAction>> CompletedActions;
m_RunningLock.WithExclusiveLock([&] {
for (auto It = begin(m_RunningMap), ItEnd = end(m_RunningMap); It != ItEnd;)
{
Ref<RunningAction> Running = It->second;
pid_t Pid = static_cast<pid_t>(reinterpret_cast<intptr_t>(Running->ProcessHandle));
int Status = 0;
pid_t Result = waitpid(Pid, &Status, WNOHANG);
if (Result == Pid)
{
if (WIFEXITED(Status))
{
Running->ExitCode = WEXITSTATUS(Status);
}
else if (WIFSIGNALED(Status))
{
Running->ExitCode = 128 + WTERMSIG(Status);
}
else
{
Running->ExitCode = 1;
}
Running->ProcessHandle = nullptr;
CompletedActions.push_back(std::move(Running));
It = m_RunningMap.erase(It);
}
else
{
++It;
}
}
});
ProcessCompletedActions(CompletedActions);
}
void
MacProcessRunner::CancelRunningActions()
{
ZEN_TRACE_CPU("MacProcessRunner::CancelRunningActions");
Stopwatch Timer;
std::unordered_map<int, Ref<RunningAction>> RunningMap;
m_RunningLock.WithExclusiveLock([&] { std::swap(RunningMap, m_RunningMap); });
if (RunningMap.empty())
{
return;
}
ZEN_INFO("cancelling all running actions");
// Send SIGTERM to all running processes first
std::vector<int> TerminatedLsnList;
for (const auto& Kv : RunningMap)
{
Ref<RunningAction> Running = Kv.second;
pid_t Pid = static_cast<pid_t>(reinterpret_cast<intptr_t>(Running->ProcessHandle));
if (kill(Pid, SIGTERM) == 0)
{
TerminatedLsnList.push_back(Kv.first);
}
else
{
ZEN_WARN("kill(SIGTERM) for LSN {} (pid {}) failed: {}", Running->Action->ActionLsn, Pid, strerror(errno));
}
}
// Wait up to 2 seconds for graceful exit, then SIGKILL if needed
for (int Lsn : TerminatedLsnList)
{
if (auto It = RunningMap.find(Lsn); It != RunningMap.end())
{
Ref<RunningAction> Running = It->second;
pid_t Pid = static_cast<pid_t>(reinterpret_cast<intptr_t>(Running->ProcessHandle));
// Poll for up to 2 seconds
bool Exited = false;
for (int i = 0; i < 20; ++i)
{
int Status = 0;
pid_t WaitResult = waitpid(Pid, &Status, WNOHANG);
if (WaitResult == Pid)
{
Exited = true;
ZEN_DEBUG("LSN {}: process exit OK", Running->Action->ActionLsn);
break;
}
usleep(100000); // 100ms
}
if (!Exited)
{
ZEN_WARN("LSN {}: process did not exit after SIGTERM, sending SIGKILL", Running->Action->ActionLsn);
kill(Pid, SIGKILL);
waitpid(Pid, nullptr, 0);
}
m_DeferredDeleter.Enqueue(Running->Action->ActionLsn, std::move(Running->SandboxPath));
Running->Action->SetActionState(RunnerAction::State::Failed);
}
}
ZEN_INFO("DONE - cancelled {} running processes (took {})", TerminatedLsnList.size(), NiceTimeSpanMs(Timer.GetElapsedTimeMs()));
}
} // namespace zen::compute
#endif
|