From a24ebc13bd3321eaef5757f6b42fd7fa2ebdfcc0 Mon Sep 17 00:00:00 2001 From: Dan Engelbrecht Date: Wed, 23 Mar 2022 17:20:39 +0100 Subject: review feedback --- zenstore/blockstore.cpp | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) (limited to 'zenstore/blockstore.cpp') diff --git a/zenstore/blockstore.cpp b/zenstore/blockstore.cpp index e865ede8a..441b5e926 100644 --- a/zenstore/blockstore.cpp +++ b/zenstore/blockstore.cpp @@ -189,12 +189,12 @@ TEST_CASE("blockstore.blockfile") File1.Create(16384); CHECK(File1.FileSize() == 16384); File1.Write("data", 5, 0); - auto DataChunk = File1.GetChunk(0, 5); + IoBuffer DataChunk = File1.GetChunk(0, 5); File1.Write("boop", 5, 5); - auto BoopChunk = File1.GetChunk(5, 5); - auto Data = static_cast(DataChunk.GetData()); + IoBuffer BoopChunk = File1.GetChunk(5, 5); + const char* Data = static_cast(DataChunk.GetData()); CHECK(std::string(Data) == "data"); - auto Boop = static_cast(BoopChunk.GetData()); + const char* Boop = static_cast(BoopChunk.GetData()); CHECK(std::string(Boop) == "boop"); File1.Flush(); } @@ -205,16 +205,16 @@ TEST_CASE("blockstore.blockfile") char DataRaw[5]; File1.Read(DataRaw, 5, 0); CHECK(std::string(DataRaw) == "data"); - auto DataChunk = File1.GetChunk(0, 5); + IoBuffer DataChunk = File1.GetChunk(0, 5); char BoopRaw[5]; File1.Read(BoopRaw, 5, 5); CHECK(std::string(BoopRaw) == "boop"); - auto BoopChunk = File1.GetChunk(5, 5); - auto Data = static_cast(DataChunk.GetData()); + IoBuffer BoopChunk = File1.GetChunk(5, 5); + const char* Data = static_cast(DataChunk.GetData()); CHECK(std::string(Data) == "data"); - auto Boop = static_cast(BoopChunk.GetData()); + const char* Boop = static_cast(BoopChunk.GetData()); CHECK(std::string(Boop) == "boop"); } @@ -231,9 +231,9 @@ TEST_CASE("blockstore.blockfile") CHECK(std::filesystem::exists(RootDirectory / "1")); - auto Data = static_cast(DataChunk.GetData()); + const char* Data = static_cast(DataChunk.GetData()); CHECK(std::string(Data) == "data"); - auto Boop = static_cast(BoopChunk.GetData()); + const char* Boop = static_cast(BoopChunk.GetData()); CHECK(std::string(Boop) == "boop"); } CHECK(std::filesystem::exists(RootDirectory / "1")); @@ -247,15 +247,14 @@ TEST_CASE("blockstore.blockfile") File1.Open(); std::error_code Ec; File1.MarkAsDeleteOnClose(Ec); - auto M = Ec.message(); CHECK(!Ec); DataChunk = File1.GetChunk(0, 5); BoopChunk = File1.GetChunk(5, 5); } - auto Data = static_cast(DataChunk.GetData()); + const char* Data = static_cast(DataChunk.GetData()); CHECK(std::string(Data) == "data"); - auto Boop = static_cast(BoopChunk.GetData()); + const char* Boop = static_cast(BoopChunk.GetData()); CHECK(std::string(Boop) == "boop"); } CHECK(!std::filesystem::exists(RootDirectory / "1")); -- cgit v1.2.3