From 37bf16575d226e6b53579eb913f70f869d3c3ec4 Mon Sep 17 00:00:00 2001 From: Stefan Boberg Date: Mon, 11 Oct 2021 13:18:37 +0200 Subject: stats: Added support for handler unregistration --- zenserver/cache/structuredcache.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'zenserver/cache/structuredcache.cpp') diff --git a/zenserver/cache/structuredcache.cpp b/zenserver/cache/structuredcache.cpp index 4a2a3748a..5166bee42 100644 --- a/zenserver/cache/structuredcache.cpp +++ b/zenserver/cache/structuredcache.cpp @@ -161,13 +161,16 @@ HttpStructuredCacheService::HttpStructuredCacheService(ZenCacheStore& InCac , m_CidStore(InCidStore) , m_UpstreamCache(std::move(UpstreamCache)) { - StatsService.RegisterHandler("z$", *this); - StatusService.RegisterHandler("z$", *this); + m_StatsService.RegisterHandler("z$", *this); + m_StatusService.RegisterHandler("z$", *this); } HttpStructuredCacheService::~HttpStructuredCacheService() { ZEN_INFO("closing structured cache"); + + m_StatsService.UnregisterHandler("z$", *this); + m_StatusService.UnregisterHandler("z$", *this); } const char* @@ -275,6 +278,7 @@ HttpStructuredCacheService::HandleCacheRecordRequest(HttpServerRequest& Request, HandleGetCacheRecord(Request, Ref, Policy); } break; + case kPut: HandlePutCacheRecord(Request, Ref, Policy); break; -- cgit v1.2.3 From eab4a19e846df1696c1fac5b25ec0e7327e8d32b Mon Sep 17 00:00:00 2001 From: Stefan Boberg Date: Mon, 11 Oct 2021 13:26:02 +0200 Subject: Ratios should not be percentages (this should be done in presentation) --- zenserver/cache/structuredcache.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'zenserver/cache/structuredcache.cpp') diff --git a/zenserver/cache/structuredcache.cpp b/zenserver/cache/structuredcache.cpp index 5166bee42..35cb02cbb 100644 --- a/zenserver/cache/structuredcache.cpp +++ b/zenserver/cache/structuredcache.cpp @@ -887,9 +887,9 @@ HttpStructuredCacheService::HandleStatsRequest(zen::HttpServerRequest& Request) Cbo.BeginObject("cache"); Cbo << "hits" << HitCount << "misses" << MissCount; - Cbo << "hit_ratio" << (TotalCount > 0 ? (double(HitCount) / double(TotalCount) * 100.0) : 0.0); + Cbo << "hit_ratio" << (TotalCount > 0 ? (double(HitCount) / double(TotalCount)) : 0.0); Cbo << "upstream_hits" << m_CacheStats.UpstreamHitCount; - Cbo << "upstream_ratio" << (HitCount > 0 ? (double(UpstreamHitCount) / double(HitCount)) * 100.0 : 0.0); + Cbo << "upstream_ratio" << (HitCount > 0 ? (double(UpstreamHitCount) / double(HitCount)) : 0.0); Cbo.EndObject(); if (m_UpstreamCache) -- cgit v1.2.3