From aeaa6e9c37f318e439ed5f23d0fec0662aea91d1 Mon Sep 17 00:00:00 2001 From: Stefan Boberg Date: Mon, 4 Oct 2021 15:24:16 +0200 Subject: clang-format --- zencore/filesystem.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'zencore/filesystem.cpp') diff --git a/zencore/filesystem.cpp b/zencore/filesystem.cpp index f6ba92f98..dce479a55 100644 --- a/zencore/filesystem.cpp +++ b/zencore/filesystem.cpp @@ -522,7 +522,7 @@ WriteFile(std::filesystem::path Path, IoBuffer Data) WriteFile(Path, &DataPtr, 1); } -IoBuffer +IoBuffer FileContents::Flatten() { if (Data.size() == 1) -- cgit v1.2.3 From 299c0a31514cc98c97aa3b07e8cc35b61c1e6d26 Mon Sep 17 00:00:00 2001 From: Stefan Boberg Date: Mon, 4 Oct 2021 17:52:36 +0200 Subject: filesystem: Added comment for future optimization opportunities in CreateDirectories --- zencore/filesystem.cpp | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'zencore/filesystem.cpp') diff --git a/zencore/filesystem.cpp b/zencore/filesystem.cpp index dce479a55..745fe0779 100644 --- a/zencore/filesystem.cpp +++ b/zencore/filesystem.cpp @@ -63,6 +63,13 @@ DeleteReparsePoint(const wchar_t* Path, DWORD dwReparseTag) bool CreateDirectories(const wchar_t* Dir) { + // This may be suboptimal, in that it appears to try and create directories + // from the root on up instead of from some directory which is known to + // be present + // + // We should implement a smarter version at some point since this can be + // pretty expensive in aggregate + return std::filesystem::create_directories(Dir); } -- cgit v1.2.3