From 54f9ad56c45e51ba0ce8a695ae30756d1b34d3ab Mon Sep 17 00:00:00 2001
From: Dan Engelbrecht <dan@engelbrecht.com>
Date: Wed, 13 Dec 2023 10:17:21 -0500
Subject: skip invalid chunks when reclaiming space in block store (#607)

* skip invalid chunks when reclaiming space in block store
---
 src/zenstore/blockstore.cpp | 13 +++++++++++++
 1 file changed, 13 insertions(+)

(limited to 'src')

diff --git a/src/zenstore/blockstore.cpp b/src/zenstore/blockstore.cpp
index a11b4a323..01d7e043c 100644
--- a/src/zenstore/blockstore.cpp
+++ b/src/zenstore/blockstore.cpp
@@ -757,10 +757,23 @@ BlockStore::ReclaimSpace(const ReclaimSnapshotState&			Snapshot,
 			if (OldBlockFile)
 			{
 				ZEN_TRACE_CPU("BlockStore::ReclaimSpace::MoveBlock");
+				uint64_t			 OldBlockSize = OldBlockFile->FileSize();
 				std::vector<uint8_t> Chunk;
 				for (const size_t& ChunkIndex : KeepMap)
 				{
 					const BlockStoreLocation ChunkLocation = ChunkLocations[ChunkIndex];
+					if (ChunkLocation.Offset + ChunkLocation.Size > OldBlockSize)
+					{
+						ZEN_WARN(
+							"ReclaimSpace skipping chunk outside of block range in '{}', Chunk start {}, Chunk size {} in Block {}, Block "
+							"size {}",
+							m_BlocksBasePath,
+							ChunkLocation.Offset,
+							ChunkLocation.Size,
+							OldBlockFile->GetPath(),
+							OldBlockSize);
+						continue;
+					}
 					Chunk.resize(ChunkLocation.Size);
 					OldBlockFile->Read(Chunk.data(), ChunkLocation.Size, ChunkLocation.Offset);
 
-- 
cgit v1.2.3