From d8d8378e83ef88780349157d8cb1d428bf015f10 Mon Sep 17 00:00:00 2001 From: Dan Engelbrecht Date: Fri, 17 May 2024 09:56:10 +0200 Subject: safer partial requests (#82) * fix partial cache miss logging * Handle zero size partial requests safer --- src/zenstore/cache/cacherpc.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/zenstore/cache/cacherpc.cpp') diff --git a/src/zenstore/cache/cacherpc.cpp b/src/zenstore/cache/cacherpc.cpp index f12cee923..d56ceb98e 100644 --- a/src/zenstore/cache/cacherpc.cpp +++ b/src/zenstore/cache/cacherpc.cpp @@ -1662,8 +1662,7 @@ CacheRpcHandler::WriteGetCacheChunksResponse([[maybe_unused]] const CacheRequest } } - CompressedBuffer PartialValue = - Request.Value.GetRange(Request.RequestedOffset, Request.RequestedSize == 0 ? 1u : Request.RequestedSize); + CompressedBuffer PartialValue = Request.Value.GetRange(Request.RequestedOffset, Request.RequestedSize); if (PartialValue) { @@ -1684,10 +1683,10 @@ CacheRpcHandler::WriteGetCacheChunksResponse([[maybe_unused]] const CacheRequest else { ZEN_WARN("GETCACHECHUNKS MISS (rawsize: {}, offset: {}, size: {}) - '{}/{}/{}/{}' in {}", - Namespace, Request.Value.DecodeRawSize(), Request.RequestedOffset, Request.RequestedSize, + Namespace, Request.Key->Key.Bucket, Request.Key->Key.Hash, Request.Key->ValueId, -- cgit v1.2.3