From 501d5e3b0be37ebceda96240af1e4d8df927d68f Mon Sep 17 00:00:00 2001 From: Dan Engelbrecht Date: Wed, 14 Aug 2024 09:23:19 +0200 Subject: improve logging on main failure (#111) * add support for indenting callstack output * Explicitly catch option-parse error and reduce log spam on bad parameters * add command line to sentry error reports * log command line at startup --- src/zencore/zencore.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/zencore/zencore.cpp') diff --git a/src/zencore/zencore.cpp b/src/zencore/zencore.cpp index 9c48b355b..6a963110b 100644 --- a/src/zencore/zencore.cpp +++ b/src/zencore/zencore.cpp @@ -82,7 +82,7 @@ AssertException::FullDescription() const noexcept { if (_Callstack) { - return fmt::format("'{}'\n{}", what(), CallstackToString(_Callstack)); + return fmt::format("'{}'\n{}", what(), CallstackToString(_Callstack, " ")); } return what(); } @@ -131,7 +131,7 @@ AssertImpl::OnAssert(const char* Filename, int LineNumber, const char* FunctionN fmt::basic_memory_buffer Message; auto Appender = fmt::appender(Message); - fmt::format_to(Appender, "{}({}): ZEN_ASSERT({})\n{}", Filename, LineNumber, Msg, CallstackToString(Callstack)); + fmt::format_to(Appender, "{}({}): ZEN_ASSERT({})\n{}", Filename, LineNumber, Msg, CallstackToString(Callstack, " ")); Message.push_back('\0'); // We use direct ZEN_LOG here instead of ZEN_ERROR as we don't care about *this* code location in the log -- cgit v1.2.3