From e7d3065cf47c9d8430be409a0c53422aea2e3532 Mon Sep 17 00:00:00 2001 From: zousar Date: Mon, 13 Apr 2026 14:08:09 -0600 Subject: Stop using O_CLOEXEC in shm_open --- src/zencore/filesystem.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/zencore/filesystem.cpp') diff --git a/src/zencore/filesystem.cpp b/src/zencore/filesystem.cpp index 70d0f32b3..debe51cc9 100644 --- a/src/zencore/filesystem.cpp +++ b/src/zencore/filesystem.cpp @@ -3462,11 +3462,12 @@ public: ZEN_UNUSED(SystemGlobal); std::string InstanceMapName = fmt::format("/{}", Name); - ScopedFd FdGuard(shm_open(InstanceMapName.c_str(), O_RDWR | O_CREAT | O_CLOEXEC, 0666)); + ScopedFd FdGuard(shm_open(InstanceMapName.c_str(), O_RDWR | O_CREAT, 0666)); if (!FdGuard) { return {}; } + fcntl(FdGuard.Fd, F_SETFD, FD_CLOEXEC); fchmod(FdGuard.Fd, 0666); int Result = ftruncate(FdGuard.Fd, Size); -- cgit v1.2.3 From ecd4acb89406cfa573d1819532dcaec2c44113f5 Mon Sep 17 00:00:00 2001 From: zousar Date: Mon, 13 Apr 2026 14:42:13 -0600 Subject: Removing CLOEXEC use on shared memory descriptors According to documentation, shm_open already sets O_CLOEXEC. --- src/zencore/filesystem.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/zencore/filesystem.cpp') diff --git a/src/zencore/filesystem.cpp b/src/zencore/filesystem.cpp index debe51cc9..5160bfdc6 100644 --- a/src/zencore/filesystem.cpp +++ b/src/zencore/filesystem.cpp @@ -3467,7 +3467,6 @@ public: { return {}; } - fcntl(FdGuard.Fd, F_SETFD, FD_CLOEXEC); fchmod(FdGuard.Fd, 0666); int Result = ftruncate(FdGuard.Fd, Size); -- cgit v1.2.3