From a58da97f98697580bf128ed5723ba720cc30f0dc Mon Sep 17 00:00:00 2001 From: Stefan Boberg Date: Sat, 1 Nov 2025 14:04:35 +0100 Subject: Various fixes to address issues flagged by gcc / non-UE toolchain build (#621) * gcc: avoid using memset on nontrivial struct * redundant `return std::move` * fixed various compilation issues flagged by gcc * fix issue in xmake.lua detecting whether we are building with the UE toolchain or not * add GCC ignore -Wundef (comment is inaccurate) * remove redundant std::move * don't catch exceptions by value * unreferenced variables * initialize "by the book" instead of memset * remove unused exception reference * add #include to fix gcc build * explicitly poulate KeyValueMap by traversing input spans fixes gcc compilation * remove unreferenced variable * eliminate redundant `std::move` which gcc complains about * fix gcc compilation by including * tag unreferenced variable to fix gcc compilation * fixes for various cases of naming members the same as their type --- src/zencore/compactbinaryutil.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/zencore/compactbinaryutil.cpp') diff --git a/src/zencore/compactbinaryutil.cpp b/src/zencore/compactbinaryutil.cpp index 074bdaffd..d9703bf1a 100644 --- a/src/zencore/compactbinaryutil.cpp +++ b/src/zencore/compactbinaryutil.cpp @@ -14,7 +14,7 @@ ValidateAndReadCompactBinaryObject(const SharedBuffer&& Payload, CbValidateError { if (OutError = ValidateCompactBinary(Payload.GetView(), CbValidateMode::Default); OutError == CbValidateError::None) { - CbObject Object(std::move(Payload)); + CbObject Object(Payload); if (Object.GetView().GetSize() != Payload.GetSize()) { OutError |= CbValidateError::OutOfBounds; -- cgit v1.2.3