From efe66a0fc6e6a7b55ea5a0d026790118171d4eca Mon Sep 17 00:00:00 2001 From: Dan Engelbrecht Date: Tue, 4 Nov 2025 20:10:06 +0100 Subject: remove --deep option for codesign as it is considered harmful (#629) * remove --deep option for codesign as it is considered harmful * sign crashpadhandler * add verbosity and strict to codesign --- scripts/bundle.lua | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) (limited to 'scripts/bundle.lua') diff --git a/scripts/bundle.lua b/scripts/bundle.lua index 1a81c9b7f..09f097c82 100644 --- a/scripts/bundle.lua +++ b/scripts/bundle.lua @@ -239,22 +239,22 @@ local function main_mac(signidentity) end ret = _exec("codesign", + "-vvv", + "-strict", "-s", signidentity, "-f", - "-v", - "--deep", "build/macosx/universal/release/zenserver") if ret > 0 then raise("Failed signing universal zenserver binary") end ret = _exec("codesign", + "-vvv", + "-strict", "-s", signidentity, "-f", - "-v", - "--deep", "build/macosx/universal/release/zen") if ret > 0 then raise("Failed signing universal zen binary") @@ -267,6 +267,17 @@ local function main_mac(signidentity) "sentry-native", "crashpad_handler") + ret = _exec("codesign", + "-vvv", + "-strict", + "-s", + signidentity, + "-f", + crashpad_handler_path) + if ret > 0 then + raise("Failed signing crashpad binary") + end + -- Zip _zip(false, "build/zenserver-macos.zip", -- cgit v1.2.3