more iterate chunk logging (#516)

* add log warnings when we can't read payloads in cas when we thing we should have them
* fix misleading option help

1 files changed, 12 insertions, 0 deletions

diff --git a/src/zenstore/filecas.cpp b/src/zenstore/filecas.cpp
index 365a933c1..103928097 100644
--- a/src/zenstore/filecas.cpp
+++ b/src/zenstore/filecas.cpp
@@ -656,6 +656,12 @@ FileCasStrategy::IterateChunks(std::span<IoHash>												 ChunkHashes,
 			ZEN_ASSERT(ChunkIndex < ChunkHashes.size());
 			const IoHash& ChunkHash = ChunkHashes[ChunkIndex];
 			IoBuffer	  Payload	= SafeOpenChunk(ChunkHash, ExpectedSize);
+			if (!Payload)
+			{
+				ShardingHelper				Name(m_RootDirectory, ChunkHash);
+				const std::filesystem::path ChunkPath = Name.ShardedPath.ToPath();
+				ZEN_WARN("Failed to fetch chunk {} from '{}', Size {}", ChunkHash, ChunkPath, ExpectedSize);
+			}
 			if (!AsyncCallback(ChunkIndex, std::move(Payload)))
 			{
 				return false;
@@ -754,6 +760,12 @@ FileCasStrategy::IterateChunks(std::function<void(const IoHash& Hash, IoBuffer&&
 		const IoHash&  ChunkHash	= RawHashes[Index];
 		const uint64_t ExpectedSize = ExpectedSizes[Index];
 		IoBuffer	   Payload		= SafeOpenChunk(ChunkHash, ExpectedSize);
+		if (!Payload)
+		{
+			ShardingHelper				Name(m_RootDirectory, ChunkHash);
+			const std::filesystem::path ChunkPath = Name.ShardedPath.ToPath();
+			ZEN_WARN("Failed to fetch chunk {} from '{}', Size {}", ChunkHash, ChunkPath, ExpectedSize);
+		}
 		Callback(ChunkHash, std::move(Payload));
 	}
 }