faster oplog validate (#408)

Improvement: Faster oplog validate to reduce GC wall time and disk I/O pressure

1 files changed, 42 insertions, 5 deletions

diff --git a/src/zenstore/blockstore.cpp b/src/zenstore/blockstore.cpp
index e0f371061..86dbcc971 100644
--- a/src/zenstore/blockstore.cpp
+++ b/src/zenstore/blockstore.cpp
@@ -153,14 +153,28 @@ void
 BlockStoreFile::Write(const void* Data, uint64_t Size, uint64_t FileOffset)
 {
 	ZEN_TRACE_CPU("BlockStoreFile::Write");
+#if ZEN_BUILD_DEBUG
+	if (uint64_t CachedFileSize = m_CachedFileSize.load(); CachedFileSize > 0)
+	{
+		ZEN_ASSERT(FileOffset + Size <= CachedFileSize);
+	}
+#endif	// ZEN_BUILD_DEBUG
 	m_File.Write(Data, Size, FileOffset);
 }
 
 void
-BlockStoreFile::Flush()
+BlockStoreFile::Flush(uint64_t FinalSize)
 {
 	ZEN_TRACE_CPU("BlockStoreFile::Flush");
 	m_File.Flush();
+	if (FinalSize != (uint64_t)-1)
+	{
+		uint64_t ExpectedSize = 0;
+		if (!m_CachedFileSize.compare_exchange_weak(ExpectedSize, FinalSize))
+		{
+			ZEN_ASSERT(m_CachedFileSize.load() == FinalSize);
+		}
+	}
 }
 
 BasicFile&
@@ -540,7 +554,7 @@ BlockStore::WriteChunk(const void* Data, uint64_t Size, uint32_t Alignment, cons
 	{
 		if (m_WriteBlock)
 		{
-			m_WriteBlock->Flush();
+			m_WriteBlock->Flush(m_CurrentInsertOffset);
 			m_WriteBlock = nullptr;
 		}
 
@@ -674,6 +688,27 @@ BlockStore::WriteChunks(std::span<const IoBuffer> Datas, uint32_t Alignment, con
 	}
 }
 
+bool
+BlockStore::HasChunk(const BlockStoreLocation& Location) const
+{
+	ZEN_TRACE_CPU("BlockStore::TryGetChunk");
+	RwLock::SharedLockScope InsertLock(m_InsertLock);
+	if (auto BlockIt = m_ChunkBlocks.find(Location.BlockIndex); BlockIt != m_ChunkBlocks.end())
+	{
+		if (const Ref<BlockStoreFile>& Block = BlockIt->second; Block)
+		{
+			InsertLock.ReleaseNow();
+
+			const uint64_t BlockSize = Block->FileSize();
+			if (Location.Offset + Location.Size <= BlockSize)
+			{
+				return true;
+			}
+		}
+	}
+	return false;
+}
+
 IoBuffer
 BlockStore::TryGetChunk(const BlockStoreLocation& Location) const
 {
@@ -706,7 +741,7 @@ BlockStore::Flush(bool ForceNewBlock)
 		{
 			if (m_WriteBlock)
 			{
-				m_WriteBlock->Flush();
+				m_WriteBlock->Flush(m_CurrentInsertOffset);
 			}
 			m_WriteBlock		  = nullptr;
 			m_CurrentInsertOffset = 0;
@@ -1097,7 +1132,7 @@ BlockStore::CompactBlocks(const BlockStoreCompactState&	  CompactState,
 					if (NewBlockFile)
 					{
 						ZEN_ASSERT_SLOW(NewBlockFile->IsOpen());
-						NewBlockFile->Flush();
+						NewBlockFile->Flush(WriteOffset);
 						uint64_t NewBlockSize = NewBlockFile->FileSize();
 						MovedSize += NewBlockSize;
 						NewBlockFile = nullptr;
@@ -1228,7 +1263,7 @@ BlockStore::CompactBlocks(const BlockStoreCompactState&	  CompactState,
 	if (NewBlockFile)
 	{
 		ZEN_ASSERT_SLOW(NewBlockFile->IsOpen());
-		NewBlockFile->Flush();
+		NewBlockFile->Flush(WriteOffset);
 		uint64_t NewBlockSize = NewBlockFile->FileSize();
 		MovedSize += NewBlockSize;
 		NewBlockFile = nullptr;
@@ -1359,6 +1394,8 @@ TEST_CASE("blockstore.blockfile")
 		CHECK(std::string(Boop) == "boop");
 		File1.Flush();
 		CHECK(File1.FileSize() == 10);
+		File1.Flush(10);
+		CHECK(File1.FileSize() == 10);
 	}
 	{
 		BlockStoreFile File1(RootDirectory / "1");