stop exceptions from leaking on threaded work (#102)

* catch exceptions in threaded work
* don't abort all project file/chunk info fetch for single failure

1 files changed, 25 insertions, 16 deletions

diff --git a/src/zenserver/projectstore/remoteprojectstore.cpp b/src/zenserver/projectstore/remoteprojectstore.cpp
index de6753a6b..15d329442 100644
--- a/src/zenserver/projectstore/remoteprojectstore.cpp
+++ b/src/zenserver/projectstore/remoteprojectstore.cpp
@@ -237,22 +237,31 @@ CreateBlock(WorkerThreadPool&											  WorkerPool,
 			{
 				return;
 			}
-			ZEN_ASSERT(!Chunks.empty());
-			size_t			 ChunkCount = Chunks.size();
-			Stopwatch		 Timer;
-			CompressedBuffer CompressedBlock = GenerateBlock(std::move(Chunks));
-			IoHash			 BlockHash		 = CompressedBlock.DecodeRawHash();
-			{
-				// We can share the lock as we are not resizing the vector and only touch BlockHash at our own index
-				RwLock::SharedLockScope __(SectionsLock);
-				Blocks[BlockIndex].BlockHash = BlockHash;
-			}
-			uint64_t BlockSize = CompressedBlock.GetCompressedSize();
-			AsyncOnBlock(std::move(CompressedBlock), BlockHash);
-			ZEN_INFO("Generated block with {} attachments in {} ({})",
-					 ChunkCount,
-					 NiceTimeSpanMs(Timer.GetElapsedTimeMs()),
-					 NiceBytes(BlockSize));
+			size_t ChunkCount = Chunks.size();
+			try
+			{
+				ZEN_ASSERT(ChunkCount > 0);
+				Stopwatch		 Timer;
+				CompressedBuffer CompressedBlock = GenerateBlock(std::move(Chunks));
+				IoHash			 BlockHash		 = CompressedBlock.DecodeRawHash();
+				{
+					// We can share the lock as we are not resizing the vector and only touch BlockHash at our own index
+					RwLock::SharedLockScope __(SectionsLock);
+					Blocks[BlockIndex].BlockHash = BlockHash;
+				}
+				uint64_t BlockSize = CompressedBlock.GetCompressedSize();
+				AsyncOnBlock(std::move(CompressedBlock), BlockHash);
+				ZEN_INFO("Generated block with {} attachments in {} ({})",
+						 ChunkCount,
+						 NiceTimeSpanMs(Timer.GetElapsedTimeMs()),
+						 NiceBytes(BlockSize));
+			}
+			catch (const std::exception& Ex)
+			{
+				RemoteResult.SetError(gsl::narrow<int>(HttpResponseCode::InternalServerError),
+									  fmt::format("Failed creating block {} with {} chunks", BlockIndex, ChunkCount),
+									  Ex.what());
+			}
 		});
 }