aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Engelbrecht <[email protected]>2023-09-29 16:13:40 +0200
committerGitHub <[email protected]>2023-09-29 16:13:40 +0200
commit499de215a72052aa117289060d5cba78beb8cce7 (patch)
treec38ee32129d7cbb9f95a1e6d1a66729aacd70ddd
parent0.2.25 (diff)
downloadzen-499de215a72052aa117289060d5cba78beb8cce7.tar.xz
zen-499de215a72052aa117289060d5cba78beb8cce7.zip
Correctly calculate the total number of RPC ops in the stats page for structured cache (#433)
Change "chunks" title to "count" for RPC chunk requests in stats page for structured cache
-rw-r--r--CHANGELOG.md4
-rw-r--r--src/zenserver/cache/httpstructuredcache.cpp4
2 files changed, 6 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b8bd80864..aa81e307b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,8 @@
##
+- Bugfix: Correctly calculate the total number of RPC ops in the stats page for structured cache
+- Bugfix: Change "chunks" title to "count" for RPC chunk requests in stats page for structured cache
+
+## 0.2.25
- Feature: Add detailed stats on requests and data sizes on a per-bucket level, use parameter `cachestorestats=true` on the `/stats/z$` endpoint to enable
- Feature: Add detailed stats on requests and data sizes on cidstore, use parameter `cidstorestats=true` on the `/stats/z$` endpoint to enable
- Feature: Dashboard now accepts parameters in the URL which is passed on to the `/stats/z$` endpoint
diff --git a/src/zenserver/cache/httpstructuredcache.cpp b/src/zenserver/cache/httpstructuredcache.cpp
index d82f4a16a..f3d5506eb 100644
--- a/src/zenserver/cache/httpstructuredcache.cpp
+++ b/src/zenserver/cache/httpstructuredcache.cpp
@@ -3260,7 +3260,7 @@ HttpStructuredCacheService::HandleStatsRequest(HttpServerRequest& Request)
Cbo << "badrequestcount" << BadRequestCount;
Cbo.BeginObject("rpc");
Cbo << "count" << RpcRequests;
- Cbo << "ops" << RpcRecordRequests + RpcValueRequests + RpcChunkRequests;
+ Cbo << "ops" << RpcRecordBatchRequests + RpcValueBatchRequests + RpcChunkBatchRequests;
Cbo.BeginObject("records");
Cbo << "count" << RpcRecordRequests;
Cbo << "ops" << RpcRecordBatchRequests;
@@ -3270,7 +3270,7 @@ HttpStructuredCacheService::HandleStatsRequest(HttpServerRequest& Request)
Cbo << "ops" << RpcValueBatchRequests;
Cbo.EndObject();
Cbo.BeginObject("chunks");
- Cbo << "chunk" << RpcChunkRequests;
+ Cbo << "count" << RpcChunkRequests;
Cbo << "ops" << RpcChunkBatchRequests;
Cbo.EndObject();
Cbo.EndObject();