aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Engelbrecht <[email protected]>2025-04-10 09:42:32 +0200
committerGitHub Enterprise <[email protected]>2025-04-10 09:42:32 +0200
commitd03a6c7824c0cf7c8925cbfd61008e305872d895 (patch)
tree94a1388a91a832b8023c3e4961e426cd041c6f16
parent5.6.4 (diff)
downloadzen-d03a6c7824c0cf7c8925cbfd61008e305872d895.tar.xz
zen-d03a6c7824c0cf7c8925cbfd61008e305872d895.zip
multpart download crash (#353)
* fix lambda capture during multipart-download
-rw-r--r--CHANGELOG.md3
-rw-r--r--src/zen/cmds/builds_cmd.cpp3
2 files changed, 5 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a0131a531..43443828b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,7 @@
##
+- Bugfix: `zen builds` multipart of dowload of large chunks could result in crash.
+
+## 5.6.4
- Improvement: `zen builds` now scavenges previous download locations for data to reduce download size, enabled by default, disable with `--enable-scavenge=false`
- Improvement: `zen builds upload` Fixed and improved layout of end of run stats output
- Improvement: `zen builds` Reduced clutter and added timing to some logging entries when `--verbose` is enabled
diff --git a/src/zen/cmds/builds_cmd.cpp b/src/zen/cmds/builds_cmd.cpp
index b33ec659d..2562d8244 100644
--- a/src/zen/cmds/builds_cmd.cpp
+++ b/src/zen/cmds/builds_cmd.cpp
@@ -6437,7 +6437,8 @@ namespace {
Work,
NetworkPool,
DownloadStats,
- [&, RemoteChunkIndex, ChunkTargetPtrs](IoBuffer&& Payload) mutable {
+ [&, TotalPartWriteCount, TotalRequestCount, RemoteChunkIndex, ChunkTargetPtrs](
+ IoBuffer&& Payload) mutable {
DownloadStats.RequestsCompleteCount++;
if (DownloadStats.RequestsCompleteCount == TotalRequestCount)
{