diff options
| author | Dan Engelbrecht <[email protected]> | 2025-06-02 19:14:28 +0200 |
|---|---|---|
| committer | GitHub Enterprise <[email protected]> | 2025-06-02 19:14:28 +0200 |
| commit | ac31b9db1055cad4e2226448c4d2f6d3af8b13f4 (patch) | |
| tree | 9c9264ffc6a53694bf95970540f332cebd33b2b5 | |
| parent | streaming none compressor (#414) (diff) | |
| download | zen-ac31b9db1055cad4e2226448c4d2f6d3af8b13f4.tar.xz zen-ac31b9db1055cad4e2226448c4d2f6d3af8b13f4.zip | |
fix cachbucket mem hit count (#415)
* Don't count a miss twice for memory stats if the entry can't be found
* changelog
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | src/zenstore/cache/cachedisklayer.cpp | 11 |
2 files changed, 8 insertions, 4 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 4d80ee543..4977b8585 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ ## - Bugfix: Remove long running exclusive namespace wide locks when dropping buckets or namespaces - Bugfix: Flush the last block before closing the last new block written to during blockstore compact. UE-291196 +- Bugfix: Fix stats for memcached entries in disk cache buckets - Feature: Drop unreachable CAS data during GC pass. UE-291196 - Improvement: Check available disk space more frequently and trigger GC operation if low water mark is reached - Improvement: Faster oplog validate to reduce GC wall time and disk I/O pressure diff --git a/src/zenstore/cache/cachedisklayer.cpp b/src/zenstore/cache/cachedisklayer.cpp index f76ad5c7d..e973cee77 100644 --- a/src/zenstore/cache/cachedisklayer.cpp +++ b/src/zenstore/cache/cachedisklayer.cpp @@ -1436,6 +1436,13 @@ ZenCacheDiskLayer::CacheBucket::EndGetBatch(GetBatchHandle* Batch) noexcept } } } + else + { + if (m_Configuration.MemCacheSizeThreshold > 0) + { + m_MemoryMissCount++; + } + } } } @@ -1669,10 +1676,6 @@ ZenCacheDiskLayer::CacheBucket::EndGetBatch(GetBatchHandle* Batch) noexcept else { m_DiskMissCount++; - if (m_Configuration.MemCacheSizeThreshold > 0) - { - m_MemoryMissCount++; - } } } } |