From 90db3ced033d4e06da2739e5d97cdeff2b0ba3b9 Mon Sep 17 00:00:00 2001
From: Stefan Boberg <stefan.boberg@epicgames.com>
Date: Tue, 11 Mar 2025 09:58:07 +0100
Subject: Build command tweaks (#301)

- Improvement: Don't chunk up .mp4 files as they generally won't benefit from deduplication or partial in-place-updates
- Improvement: Emit build name to console output when downloading a build
- Improvement: Added some debug logging
- Bugfix: Logging setup would previously not function correctly when not logging to file
---
 src/zen/cmds/builds_cmd.cpp | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

(limited to 'src/zen/cmds/builds_cmd.cpp')

diff --git a/src/zen/cmds/builds_cmd.cpp b/src/zen/cmds/builds_cmd.cpp
index 2c7a73fb3..56c3c3c4f 100644
--- a/src/zen/cmds/builds_cmd.cpp
+++ b/src/zen/cmds/builds_cmd.cpp
@@ -5,6 +5,7 @@
 #include <zencore/basicfile.h>
 #include <zencore/compactbinarybuilder.h>
 #include <zencore/compactbinaryfile.h>
+#include <zencore/compactbinaryfmt.h>
 #include <zencore/compress.h>
 #include <zencore/except.h>
 #include <zencore/filesystem.h>
@@ -5699,10 +5700,14 @@ namespace {
 			std::vector<std::pair<Oid, std::string>> AvailableParts;
 
 			CbObject BuildObject = Storage.GetBuild(BuildId);
-			ZEN_CONSOLE("GetBuild took {}. Payload size: {}",
+
+			ZEN_CONSOLE("GetBuild took {}. Name: '{}', Payload size: {}",
 						NiceTimeSpanMs(GetBuildTimer.GetElapsedTimeMs()),
+						BuildObject["BuildName"sv].AsString(),
 						NiceBytes(BuildObject.GetSize()));
 
+			ZEN_DEBUG("Build object: {}", BuildObject);
+
 			CbObjectView PartsObject = BuildObject["parts"sv].AsObjectView();
 			if (!PartsObject)
 			{
@@ -5782,11 +5787,13 @@ namespace {
 	{
 		ZEN_TRACE_CPU("GetRemoteContent");
 
-		Stopwatch GetBuildPartTimer;
-		CbObject  BuildPartManifest = Storage.GetBuildPart(BuildId, BuildParts[0].first);
+		Stopwatch			   GetBuildPartTimer;
+		const Oid			   BuildPartId		 = BuildParts[0].first;
+		const std::string_view BuildPartName	 = BuildParts[0].second;
+		CbObject			   BuildPartManifest = Storage.GetBuildPart(BuildId, BuildPartId);
 		ZEN_CONSOLE("GetBuildPart {} ('{}') took {}. Payload size: {}",
-					BuildParts[0].first,
-					BuildParts[0].second,
+					BuildPartId,
+					BuildPartName,
 					NiceTimeSpanMs(GetBuildPartTimer.GetElapsedTimeMs()),
 					NiceBytes(BuildPartManifest.GetSize()));
 
@@ -5915,7 +5922,7 @@ namespace {
 		OutPartContents.resize(1);
 		ParseBuildPartManifest(Storage,
 							   BuildId,
-							   BuildParts[0].first,
+							   BuildPartId,
 							   BuildPartManifest,
 							   OutPartContents[0],
 							   OutBlockDescriptions,
-- 
cgit v1.2.3