oplog prep gc fix (#216)

- Added option gc-validation to zenserver that does a check for missing references in all oplog post full GC. Enabled by default.
- Feature: Added option gc-validation to zen gc command to control reference validation. Enabled by default.
- Added more details in post GC log.
- Fixed race condition in oplog writes which could cause used attachments to be incorrectly removed by GC

1 files changed, 8 insertions, 0 deletions

diff --git a/src/zen/cmds/admin_cmd.cpp b/src/zen/cmds/admin_cmd.cpp
index 3b24b9078..e07e28f54 100644
--- a/src/zen/cmds/admin_cmd.cpp
+++ b/src/zen/cmds/admin_cmd.cpp
@@ -149,6 +149,13 @@ GcCommand::GcCommand()
 						 "Enable storing attachments referenced by project oplogs in meta data",
 						 cxxopts::value(m_StoreProjectAttachmentMetaData)->default_value("false"),
 						 "<project-attachments-store>");
+
+	m_Options.add_option("",
+						 "",
+						 "gc-validation",
+						 "Enable validation of references after full GC.",
+						 cxxopts::value(m_EnableValidation)->default_value("true"),
+						 "<cache-attachments-store>");
 }
 
 GcCommand::~GcCommand()
@@ -237,6 +244,7 @@ GcCommand::Run(const ZenCliOptions& GlobalOptions, int argc, char** argv)
 	{
 		Params.Add({"storeprojectattachmentmetadata", m_StoreProjectAttachmentMetaData ? "true" : "false"});
 	}
+	Params.Add({"enablevalidation", m_EnableValidation ? "true" : "false"});
 
 	cpr::Session Session;
 	Session.SetHeader(cpr::Header{{"Accept", "application/json"}});